• Announcements

    • boen_robot

      Guidelines and Netiquette   03/28/2017

      Posting Problems:   Having problems posting your topic? Read through this: To join, you agree to our terms and conditions and fill out and submit a registration form. An activation email will be sent to your email adress, so you'll need to verify your account. After that the account has to be validated by one of the moderators. This will mean that it can take up to a day to be activated. A couple of things to remember to ensure approval: Don't use an email address in one of those $2 four character .com domains eg. xyds.com. These will be deleted and the domain added to the banned list. Don't use an email address that is within a domain with a bad reputation for spam. A Google search is run on every email address and email domain. Don't sign up with an email address that doesn't exist, doesn't work or requires the sender to answer a quiz before their email can get to you. Put your country and or state and city in the signup form. Blank forms will go to the botton of the "to do" list. And make sure that your email address and your country match, saying you're from Alabama and using a .ru email address is not going to get you activated. After a membership is activated the first few posts will be monitored. Posting spam or unapproved topics described in the agreement results in an immediate ban. The email provider and the IP addresses associated with the account will be banned and all posts will be deleted. These strict measures have been deemed necessary to hinder spam. Sorry for any inconvenience this causes, but it's not liable to change. If, after reading this, you still can't post and don't understand why, contact one of the Moderators listed here.   Topic Guidelines   Including the following information can expedite an accurate response from board members: Must be a Specific Problem or Question related to web design and development Include Code in Question (wrap with   for small blocks of code and for longer blocks   ) Include Code Author Include Extra Notes/Modifications/Attempts Include web link to page/file when possible Content Guidelines   You may not post, upload, link to, or email any Content that contains, promotes, gives instruction about, or provides prohibited Content. Prohibited Content includes any Content that breaks any local, state, county, national or international law. Prohibited Content also includes: No direct or indirect advertising or websites, forums, products, services No hijacking of posts (do not post your question in someone elses) Content that infringes upon any rights [ex. MP3s and ROMs] (including, but not limited to, copyrights and trademarks) Abusive, threatening, defamatory, racist, or obscene Viruses or any other harmful computer software False Information or libel Spam, chain letters, or Pyramid schemes Gambling or Illicit drugs Terrorism Hacking or cheating for internet/online games Warez, Roms, CD-Keys, Cracks, Passwords, or Serial Numbers Pornography, nudity, or sexual material of any kind Excessive profanity Invasive of privacy or impersonation of any person/entity Hacking materials or information Posting Tips   There are more BBcodes than there are buttons for on the reply menu. To get the full list, click "BB Code Help" underneath the clickable smilie face menu. Use   for small snippets of code Use   for lengthy snippets of code Use   if your snippet is HTML (optional) Use   if your snippet is SQL (optional) Rules of Conduct   Be nice. There's no need for calling someone stupid if they ask an 'easy' question. Keep your avatars and signatures absolutely child friendly. We have a younger audience on this forum. Keep your language appropriate for the same reason above. Do not PM moderators for help on the forum. Post on the topic, or create a new one.   Spam:   Recently, as you have all without doubt noticed, we have had lots of spam and advertisement on the forum. Therefore, we'd like to alert you as to what to do when you have found any of the aforementioned annoying messages: it. Immediately. Give a clear reason, please, if the advertising is not evident. DO NOT POST! Report, let the post stay as is, and we will get to it, meanwhile if you continue to post as normal in the other threads, it won't be on the top so long. Refrain from PMing the member. This won't help at all, as they are most likely spambots anyway. Thank you.       Images in signatures:   After thinking of users on dial-up, we have decided to enforce the following rules regarding signatures. Please pay heed to them. Respecting these rules is respecting the members on this forum with dial-up. Signature rules: No animated images AT ALL. No matter the amount of animation. Maximum image widthxheight: 300x150 Maximum image (file) size: 15kb Use calm colors. Do not use highly contrasting images in your signature, as this can get really annoying when seeing several posts from one member in the same thread. The same prohibited content goes for images as for posts. Lastly, use common sense. No lengthy signatures please. Save us some scrolling. Thank you.       Links in signatures:   Please understand that w3schools.com only exists because of voluntary work and is barely supported by the advertising littered throughout the tutorials and the forum. So, please, stop advertising other sites. DO not post links that drive traffic away from the w3schools domain - especially to a site that offers similar if not identical information. Please help support the site by keeping individuals on it. Thank you. Here are some guidelines as to what you can put in your signature: w3schools links --> allowed w3.org links --> allowed browser links --> allowed html editor links --> allowed personal sites --> allowed tutorial sites competing with w3schools --> NOT allowed sites completely irrelevant to webprogramming and this forum --> NOT allowed   Thanks for understanding, and for taking the time to read this. ~W3Schools Modstaff~
nickc

Small screen menu not collapsing after click

18 posts in this topic

Hello

 

I have built a one page website based on this template - http://www.w3schools.com/w3css/tryw3css_templates_website.htm

 

When viewed a smartphone screen the smallscreen navbar does not collapse after clicking a link and I therefore have to toggle the nav button manually.

 

I have created a workaround in order for the site to function as desired which can be found here - http://www.davidclarkandco.co.uk/index.html - but ideally I simply wish to use a single page and have the menu to collapse on click.

 

Thanks in advance for advice/help.

Share this post


Link to post
Share on other sites

You can add a click event to all the links within the menu to make the menu collapse.

Share this post


Link to post
Share on other sites

You can add a click event to all the links within the menu to make the menu collapse.

 

Thanks. Any chance of a pointer as to how I might implement that?

Share this post


Link to post
Share on other sites

Have you learned Javascript yet?

Share this post


Link to post
Share on other sites

Have you learned Javascript yet?

 

I have done some in the past and am aware of onclick events. If it can be done that way I'm happy to go with that. Just wasn't sure it was possible with W3.CSS as all the solutions I've found so far relate to bootstrap.

Share this post


Link to post
Share on other sites

Unlike Bootstrap, W3.CSS does not use any Javascript. If you look at the example page, what they've done is add Javascript to it. If you look at the bottom of the page, they've defined a function called openNav().

 

What you can do is go through each of the links and have them call openNav when clicked.

// Get a list of links
var links = document.querySelectorAll(".w3-navbar .w3-hide-small > a");

// Loop through the links to add the event listener
for(var i = 0; i < links.length; i++) {
  links[i].addEventListener("click", openNav, false);
}

Share this post


Link to post
Share on other sites

 

Unlike Bootstrap, W3.CSS does not use any Javascript. If you look at the example page, what they've done is add Javascript to it. If you look at the bottom of the page, they've defined a function called openNav().

 

What you can do is go through each of the links and have them call openNav when clicked.

// Get a list of links
var links = document.querySelectorAll(".w3-navbar .w3-hide-small > a");

// Loop through the links to add the event listener
for(var i = 0; i < links.length; i++) {
  links[i].addEventListener("click", openNav, false);
}

 

Fabulous. It works. Thanks so much!

Share this post


Link to post
Share on other sites

Unlike Bootstrap, W3.CSS does not use any Javascript.

Err, yes! It does, massively so, difference, bootstrap is unobtrusive, w3.css is all inline to elements and page itself.

Share this post


Link to post
Share on other sites

That's not part of the W3.CSS framework, they just add Javascript onto the page in the examples specifically because it's not included in the framework.

Share this post


Link to post
Share on other sites

Yes, but without any of javascript provided in examples, the css on its on is pretty much useless. It would be like having a car without an engine.

Share this post


Link to post
Share on other sites

I think the point they're trying to get with these examples is that if you want something done with Javascript you have to write the Javascript yourself, the framework is a purely CSS framework intended just for presentation and not behavior.

Share this post


Link to post
Share on other sites

To claim its just css is a stupid statement, as mentioned most of its examples would not work without them adding JavaScript specifically for there w3css examples.

 

Take for instance, there many templates, why include javscript for templates, you have html with w3css classes, and css, just add your own JavaScript so it will work as w3css intended. Going by that statement every website is just a css framework for presentational, with just our own added JavaScript to make it behavioral.

Share this post


Link to post
Share on other sites

The difference between W3.CSS and Bootstrap is that Bootstrap comes with a bootstrap.js file while W3.CSS has no associated JS file in the framework. You just include w3.css in your website and everything else has to be added manually on top.

Share this post


Link to post
Share on other sites

So just because they can't be bothered to add all THEIR JavaScript code into one JavaScript file, to make THEIR template behavioral, its still only a css framework, no! I really don't think so.

Share this post


Link to post
Share on other sites

Hi, I have the same problem as Nickc and I have tried to solve it as Ingolme has offered. Unfortunately I failed. Please tell me where the mistake is. I would be very thankful for help. Below is the script

<div class="w3-padding-0 w3-large w3-text-grey" style="font-weight:bold">
    <a onclick="myAccFunc()" class="w3-button w3-block w3-white w3-left-align"> Наши проекты <i class="fa fa-caret-down"></i></a>
    <div id="demoAcc" href="javascript:void(0)" class="w3-bar-block w3-hide w3-padding-large w3-medium">
      <a href="http://тетрадкадружбы.заботадетям.рф" class="w3-bar-item w3-button w3-light-grey"><i class="fa fa-caret-right w3-margin-right"></i>Тетрадка дружбы</a>
      <a href="http://стритбол.заботадетям.рф" class="w3-bar-item w3-button w3-light-grey"><i class="fa fa-caret-right w3-margin-right"></i>Стритбол</a>
      <a href="http://даридобро.заботадетям.рф" class="w3-bar-item w3-button w3-light-grey"><i class="fa fa-caret-right w3-margin-right"></i>Дари добро</a>
      <a href="http://домребенка.заботадетям.рф" class="w3-bar-item w3-button w3-light-grey"><i class="fa fa-caret-right w3-margin-right"></i>Дом ребенка</a>
      <a href="http://времяцветов.заботадетям.рф" class="w3-bar-item w3-button w3-light-grey"><i class="fa fa-caret-right w3-margin-right"></i>Время цветов</a>
    </div>
    <a href="http://помочь.заботадетям.рф" class="w3-bar-item w3-button">Как помочь</a>
    <div id="navDemo" href="javascript:void(0)">
    <a onclick="openNav()" href="#about" class="w3-bar-item w3-button">О нашем фонде</a>
    <a onclick="openNav()" href="#mission" class="w3-bar-item w3-button">Миссия фонда</a>
    <a onclick="openNav()" href="#docs" class="w3-bar-item w3-button">Учредительные документы</a>   
    <a onclick="openNav()" href="#team" class="w3-bar-item w3-button">Координаторы</a>
    <a onclick="openNav()" href="#rewards" class="w3-bar-item w3-button">Благодарности</a>
    <a onclick="openNav()" href="#contact" class="w3-bar-item w3-button">Контакты</a>
    </div>
  </div>

 

<script>
// Accordion
function myAccFunc() {
    var x = document.getElementById("demoAcc");
    if (x.className.indexOf("w3-show") == -1) {
        x.className += " w3-show";
    } else {
        x.className = x.className.replace(" w3-show", "");
    }
}
// Script to open and close sidebar
function w3_open() {
    document.getElementById("mySidebar").style.display = "block";
    document.getElementById("myOverlay").style.display = "block";
}
 
function w3_close() {
    document.getElementById("mySidebar").style.display = "none";
    document.getElementById("myOverlay").style.display = "none";
}
// Used to toggle the menu on smaller screens when clicking on the menu button
function openNav() {
    var x = document.getElementById("navDemo");
    if (x.className.indexOf("w3-show") == -1) {
        x.className += " w3-show";
    } else {
        x.className = x.className.replace(" w3-show", "");
    }
}
</script>

Share this post


Link to post
Share on other sites

(1) Div element cannot use href attribute, they are only for anchor 'a' elements.

(2)  var x = document.getElementById("navDemo");  assign a element with id ref 'navDemo' ie <div id="navDemo" href="javascript:void(0)"> (with invalid href attribute) to variable 'x'

then it checks this specific element classes?

if (x.className.indexOf("w3-show") == -1) {
        x.className += " w3-show";
    } else {
        x.className = x.className.replace(" w3-show", "");
    }

but! can you see the problem here? there are no classes for this element.

Share this post


Link to post
Share on other sites

Posted (edited)

On ‎20‎.‎09‎.‎2016 at 11:38 PM, nickc said:

Thank you, I have corrected the Div element and replaced href attribute to the <a> line above. What about onclick attributes? Shall I also replace script to the one below? :

// Get a list of links

var links = document.querySelectorAll(".w3-navbar .w3-hide-small > a");

// Loop through the links to add the event listener

for(var i = 0; i < links.length; i++) { links[i].addEventListener("click", openNav, false);

}

 

 

Edited by Roman Heidemann

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now