• Announcements

    • boen_robot

      Guidelines and Netiquette   03/28/2017

      Posting Problems:   Having problems posting your topic? Read through this: To join, you agree to our terms and conditions and fill out and submit a registration form. An activation email will be sent to your email adress, so you'll need to verify your account. After that the account has to be validated by one of the moderators. This will mean that it can take up to a day to be activated. A couple of things to remember to ensure approval: Don't use an email address in one of those $2 four character .com domains eg. xyds.com. These will be deleted and the domain added to the banned list. Don't use an email address that is within a domain with a bad reputation for spam. A Google search is run on every email address and email domain. Don't sign up with an email address that doesn't exist, doesn't work or requires the sender to answer a quiz before their email can get to you. Put your country and or state and city in the signup form. Blank forms will go to the botton of the "to do" list. And make sure that your email address and your country match, saying you're from Alabama and using a .ru email address is not going to get you activated. After a membership is activated the first few posts will be monitored. Posting spam or unapproved topics described in the agreement results in an immediate ban. The email provider and the IP addresses associated with the account will be banned and all posts will be deleted. These strict measures have been deemed necessary to hinder spam. Sorry for any inconvenience this causes, but it's not liable to change. If, after reading this, you still can't post and don't understand why, contact one of the Moderators listed here.   Topic Guidelines   Including the following information can expedite an accurate response from board members: Must be a Specific Problem or Question related to web design and development Include Code in Question (wrap with   for small blocks of code and for longer blocks   ) Include Code Author Include Extra Notes/Modifications/Attempts Include web link to page/file when possible Content Guidelines   You may not post, upload, link to, or email any Content that contains, promotes, gives instruction about, or provides prohibited Content. Prohibited Content includes any Content that breaks any local, state, county, national or international law. Prohibited Content also includes: No direct or indirect advertising or websites, forums, products, services No hijacking of posts (do not post your question in someone elses) Content that infringes upon any rights [ex. MP3s and ROMs] (including, but not limited to, copyrights and trademarks) Abusive, threatening, defamatory, racist, or obscene Viruses or any other harmful computer software False Information or libel Spam, chain letters, or Pyramid schemes Gambling or Illicit drugs Terrorism Hacking or cheating for internet/online games Warez, Roms, CD-Keys, Cracks, Passwords, or Serial Numbers Pornography, nudity, or sexual material of any kind Excessive profanity Invasive of privacy or impersonation of any person/entity Hacking materials or information Posting Tips   There are more BBcodes than there are buttons for on the reply menu. To get the full list, click "BB Code Help" underneath the clickable smilie face menu. Use   for small snippets of code Use   for lengthy snippets of code Use   if your snippet is HTML (optional) Use   if your snippet is SQL (optional) Rules of Conduct   Be nice. There's no need for calling someone stupid if they ask an 'easy' question. Keep your avatars and signatures absolutely child friendly. We have a younger audience on this forum. Keep your language appropriate for the same reason above. Do not PM moderators for help on the forum. Post on the topic, or create a new one.   Spam:   Recently, as you have all without doubt noticed, we have had lots of spam and advertisement on the forum. Therefore, we'd like to alert you as to what to do when you have found any of the aforementioned annoying messages: it. Immediately. Give a clear reason, please, if the advertising is not evident. DO NOT POST! Report, let the post stay as is, and we will get to it, meanwhile if you continue to post as normal in the other threads, it won't be on the top so long. Refrain from PMing the member. This won't help at all, as they are most likely spambots anyway. Thank you.       Images in signatures:   After thinking of users on dial-up, we have decided to enforce the following rules regarding signatures. Please pay heed to them. Respecting these rules is respecting the members on this forum with dial-up. Signature rules: No animated images AT ALL. No matter the amount of animation. Maximum image widthxheight: 300x150 Maximum image (file) size: 15kb Use calm colors. Do not use highly contrasting images in your signature, as this can get really annoying when seeing several posts from one member in the same thread. The same prohibited content goes for images as for posts. Lastly, use common sense. No lengthy signatures please. Save us some scrolling. Thank you.       Links in signatures:   Please understand that w3schools.com only exists because of voluntary work and is barely supported by the advertising littered throughout the tutorials and the forum. So, please, stop advertising other sites. DO not post links that drive traffic away from the w3schools domain - especially to a site that offers similar if not identical information. Please help support the site by keeping individuals on it. Thank you. Here are some guidelines as to what you can put in your signature: w3schools links --> allowed w3.org links --> allowed browser links --> allowed html editor links --> allowed personal sites --> allowed tutorial sites competing with w3schools --> NOT allowed sites completely irrelevant to webprogramming and this forum --> NOT allowed   Thanks for understanding, and for taking the time to read this. ~W3Schools Modstaff~
jake

Modal form display not being set to none on click

7 posts in this topic

 

Hello everyone, I am trying to make my first website and have been going through some javascript examples on W3S to learn how to make a website more interactive. I have been looking at the code for modal login and signup forms found here: 

https://www.w3schools.com/howto/howto_css_login_form.asp

and here:

https://www.w3schools.com/howto/howto_css_signup_form.asp

 

The HTML and CSS are easy enough to understand I think, but I seem to be having some trouble with the JS aspect of the tutorials. What I have done is simply add both forms to an HTML document, linked to the styling and that seems to be working fine. The problem is when I click outside of the form the display for the modal forms should be set to none by the javascript code but this only works for one button. I have been able to rearrange some of the code so the second button works but then the first button wouldn't work. I have the code listed below. I've been trying this for a few days and would really like some help. Thanks in advance.

 

HTML:

<!DOCTYPE html>
<html>
	<head>
		<meta charset="utf-8">
		<title>Website3</title>
		<link rel="stylesheet" href="reset.css">
		<link rel="stylesheet" href="style.css">
		<link rel="stylesheet" href="login.css">
	</head>
	<body>
		<div id="outerMain">
			<div id="main">
				<header>
					<button onclick="document.getElementById('id01').style.display='block'" style="width:auto;">Login</button>
					<button onclick="document.getElementById('id02').style.display='block'" style="width:auto;">Sign Up</button>

					<div id="id01" class="modal">

					  <form class="modal-content animate" action="/action_page.php">
					    <div class="imgcontainer">
					      <span onclick="document.getElementById('id01').style.display='none'" class="close" title="Close Modal">&times;</span>
					      <img src="logo.png" alt="Avatar" class="avatar">
					    </div>

					    <div class="container">
					      <label><b>Username</b></label>
					      <input type="text" placeholder="Enter Username" name="uname" required>

					      <label><b>Password</b></label>
					      <input type="password" placeholder="Enter Password" name="psw" required>

					      <button type="submit">Login</button>
					      <input type="checkbox" checked="checked"> Remember me
					    </div>

					    <div class="container" style="background-color:#f1f1f1">
					      <button type="button" onclick="document.getElementById('id01').style.display='none'" class="cancelbtn">Cancel</button>
					      <span class="psw">Forgot <a href="#">password?</a></span>
					    </div>
					  </form>
					</div>
					<div id="id02" class="modal">
  					<form class="modal-content animate" action="/action_page.php">
							<div class="imgcontainer">
					      <span onclick="document.getElementById('id02').style.display='none'" class="close" title="Close Modal">&times;</span>
					    </div>
    					<div class="container">
      					<label><b>Email</b></label>
      					<input type="text" placeholder="Enter Email" name="email" required>

      					<label><b>Password</b></label>
      					<input type="password" placeholder="Enter Password" name="psw" required>

      					<label><b>Repeat Password</b></label>
      					<input type="password" placeholder="Repeat Password" name="psw-repeat" required>
      					<input type="checkbox" checked="checked"> Remember me
      					<p>By creating an account you agree to our <a href="#">Terms & Privacy</a>.</p>

      					<div class="clearfix">
        					<button type="button" onclick="document.getElementById('id02').style.display='none'" 		class="cancelbtn">Cancel</button>
        					<button type="submit" class="signupbtn">Sign Up</button>
      					</div>
    					</div>
  					</form>
					</div>
					<script src="scripts.js">
					</script>
				</header>
				<section>
					<center><img src="centerimg.png" alt=""></center>
				</section>
			</div>
		</div>
		<footer>
			<center>HERE IS THE FOOTER!!</center>
		</footer>
	</body>
</html>

Javascript:

var login = document.getElementById('id01');
var modal = document.getElementById('id02');


console.log(login);
console.log(modal);

if(login == document.getElementById('id01')){

	console.log(login);

		window.onclick = function(event) {
    	if (event.target == login) {
        	login.style.display = "none";
    }
};
}

window.onclick = function(event) {
    if (event.target == modal) {
        modal.style.display = "none";
    }
};

 

CSS:

 

html,body{
	height: 100%;
}

#outerMain {
	min-height: 100%;

}

#main{
	overflow: auto;
	padding-bottom: 100px;
	background-color: green;
}

header{
	background-color: blue;
	

}

/* Full-width input fields */
input[type=text], input[type=password] {
    width: 100%;
    padding: 12px 20px;
    margin: 8px 0;
    display: inline-block;
    border: 1px solid #ccc;
    box-sizing: border-box;
}

/* Set a style for all buttons */
button {
    background-color: #4CAF50;
    color: white;
    padding: 14px 20px;
    margin: 8px 0;
    border: none;
    cursor: pointer;
    width: 100%;
		
}

button:hover {
    opacity: 0.8;
}

/* Extra styles for the cancel button */
.cancelbtn {
    width: auto;
    padding: 10px 18px;
    background-color: #f44336;
}

/* Center the image and position the close button */
.imgcontainer {
    text-align: center;
    margin: 24px 0 12px 0;
    position: relative;
}

img.avatar {
    width: 40%;
    border-radius: 50%;
}

.container {
    padding: 16px;
}

span.psw {
    float: right;
    padding-top: 16px;
}

/* The Modal (background) */
.modal {
    display: none; /* Hidden by default */
    position: fixed; /* Stay in place */
    z-index: 1; /* Sit on top */
    left: 0;
    top: 0;
    width: 100%; /* Full width */
    height: 100%; /* Full height */
    overflow: auto; /* Enable scroll if needed */
    background-color: rgb(0,0,0); /* Fallback color */
    background-color: rgba(0,0,0,0.4); /* Black w/ opacity */
    padding-top: 60px;
}

/* Modal Content/Box */
.modal-content {
    background-color: #fefefe;
    margin: 5% auto 15% auto; /* 5% from the top, 15% from the bottom and centered */
    border: 1px solid #888;
    width: 80%; /* Could be more or less, depending on screen size */
}

/* The Close Button (x) */
.close {
    position: absolute;
    right: 25px;
    top: 0;
    color: #000;
    font-size: 35px;
    font-weight: bold;
}

.close:hover,
.close:focus {
    color: red;
    cursor: pointer;
}

/* Add Zoom Animation */
.animate {
    -webkit-animation: animatezoom 0.6s;
    animation: animatezoom 0.6s
}

@-webkit-keyframes animatezoom {
    from {-webkit-transform: scale(0)}
    to {-webkit-transform: scale(1)}
}

@keyframes animatezoom {
    from {transform: scale(0)}
    to {transform: scale(1)}
}

/* Change styles for span and cancel button on extra small screens */
@media screen and (max-width: 300px) {
    span.psw {
       display: block;
       float: none;
    }
    .cancelbtn {
       width: 100%;
    }
}


 

Share this post


Link to post
Share on other sites

Place both if conditions for setting modal and login to  display none, in a single window.onclick function

1 person likes this

Share this post


Link to post
Share on other sites

This worked, thank you very much. What led you to this solution? Is there something specific about the window.onclick function that prevents two from being used in the same script?

Share this post


Link to post
Share on other sites

You can only have one onclick event per element, having multiple will cause one to overide the other, plus the idea is to set ALL events on the loading of page, not when a specific condition is  met, later on. With a single event you can then check for multiple conditions before making adjustments to specific elements.

Share this post


Link to post
Share on other sites
7 hours ago, dsonesuk said:

plus the idea is to set ALL events on the loading of page, not when a specific condition is  met, later on. With a single event you can then check for multiple conditions before making adjustments to specific elements.

3

What do you mean?

Share this post


Link to post
Share on other sites

Events such as click, mouseover, mouseout are added to elements when page is fully loaded and the targeted elements exist, even inline events onclick="dothis()" are added when the element exist as the page is rendered from top to bottom. As mentioned multiple identical events targeting same elements will be overriding by the last, so a single event on which you can check multiple conditions as in

if (event.target == modal) {
        modal.style.display = "none";
    }

And

if (event.target == login) {
       login.style.display = "none";
    }

Can be carried out under the same event targeting the same element (window), if true carry out required adjustment 'login.style.display = "none";' else ignore move to next.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now