• Announcements

    • boen_robot

      Guidelines and Netiquette   03/28/2017

      Posting Problems:   Having problems posting your topic? Read through this: To join, you agree to our terms and conditions and fill out and submit a registration form. An activation email will be sent to your email adress, so you'll need to verify your account. After that the account has to be validated by one of the moderators. This will mean that it can take up to a day to be activated. A couple of things to remember to ensure approval: Don't use an email address in one of those $2 four character .com domains eg. xyds.com. These will be deleted and the domain added to the banned list. Don't use an email address that is within a domain with a bad reputation for spam. A Google search is run on every email address and email domain. Don't sign up with an email address that doesn't exist, doesn't work or requires the sender to answer a quiz before their email can get to you. Put your country and or state and city in the signup form. Blank forms will go to the botton of the "to do" list. And make sure that your email address and your country match, saying you're from Alabama and using a .ru email address is not going to get you activated. After a membership is activated the first few posts will be monitored. Posting spam or unapproved topics described in the agreement results in an immediate ban. The email provider and the IP addresses associated with the account will be banned and all posts will be deleted. These strict measures have been deemed necessary to hinder spam. Sorry for any inconvenience this causes, but it's not liable to change. If, after reading this, you still can't post and don't understand why, contact one of the Moderators listed here.   Topic Guidelines   Including the following information can expedite an accurate response from board members: Must be a Specific Problem or Question related to web design and development Include Code in Question (wrap with   for small blocks of code and for longer blocks   ) Include Code Author Include Extra Notes/Modifications/Attempts Include web link to page/file when possible Content Guidelines   You may not post, upload, link to, or email any Content that contains, promotes, gives instruction about, or provides prohibited Content. Prohibited Content includes any Content that breaks any local, state, county, national or international law. Prohibited Content also includes: No direct or indirect advertising or websites, forums, products, services No hijacking of posts (do not post your question in someone elses) Content that infringes upon any rights [ex. MP3s and ROMs] (including, but not limited to, copyrights and trademarks) Abusive, threatening, defamatory, racist, or obscene Viruses or any other harmful computer software False Information or libel Spam, chain letters, or Pyramid schemes Gambling or Illicit drugs Terrorism Hacking or cheating for internet/online games Warez, Roms, CD-Keys, Cracks, Passwords, or Serial Numbers Pornography, nudity, or sexual material of any kind Excessive profanity Invasive of privacy or impersonation of any person/entity Hacking materials or information Posting Tips   There are more BBcodes than there are buttons for on the reply menu. To get the full list, click "BB Code Help" underneath the clickable smilie face menu. Use   for small snippets of code Use   for lengthy snippets of code Use   if your snippet is HTML (optional) Use   if your snippet is SQL (optional) Rules of Conduct   Be nice. There's no need for calling someone stupid if they ask an 'easy' question. Keep your avatars and signatures absolutely child friendly. We have a younger audience on this forum. Keep your language appropriate for the same reason above. Do not PM moderators for help on the forum. Post on the topic, or create a new one.   Spam:   Recently, as you have all without doubt noticed, we have had lots of spam and advertisement on the forum. Therefore, we'd like to alert you as to what to do when you have found any of the aforementioned annoying messages: it. Immediately. Give a clear reason, please, if the advertising is not evident. DO NOT POST! Report, let the post stay as is, and we will get to it, meanwhile if you continue to post as normal in the other threads, it won't be on the top so long. Refrain from PMing the member. This won't help at all, as they are most likely spambots anyway. Thank you.       Images in signatures:   After thinking of users on dial-up, we have decided to enforce the following rules regarding signatures. Please pay heed to them. Respecting these rules is respecting the members on this forum with dial-up. Signature rules: No animated images AT ALL. No matter the amount of animation. Maximum image widthxheight: 300x150 Maximum image (file) size: 15kb Use calm colors. Do not use highly contrasting images in your signature, as this can get really annoying when seeing several posts from one member in the same thread. The same prohibited content goes for images as for posts. Lastly, use common sense. No lengthy signatures please. Save us some scrolling. Thank you.       Links in signatures:   Please understand that w3schools.com only exists because of voluntary work and is barely supported by the advertising littered throughout the tutorials and the forum. So, please, stop advertising other sites. DO not post links that drive traffic away from the w3schools domain - especially to a site that offers similar if not identical information. Please help support the site by keeping individuals on it. Thank you. Here are some guidelines as to what you can put in your signature: w3schools links --> allowed w3.org links --> allowed browser links --> allowed html editor links --> allowed personal sites --> allowed tutorial sites competing with w3schools --> NOT allowed sites completely irrelevant to webprogramming and this forum --> NOT allowed   Thanks for understanding, and for taking the time to read this. ~W3Schools Modstaff~
Shinori

[Solved] Trouble with changing img src (HTML/JS)

9 posts in this topic

Posted (edited)

Dear W3Schools-Community,

There is something not working with my code right here. It should be mentioned that I am fairly new to using JavaScript.
Here is my HTML code (stripped down to the essential parts): 

<!DOCTYPE html>
<html lang="de">
<head>
	<script type="text/javascript">
		function change_content(contentname)
		{
			if (document.getElementById(contentname).className = 'notactive')
			{
				document.getElementById('login').className = 'notactive';
				document.getElementById('news').className = 'notactive';
				document.getElementById('info').className = 'notactive';
				document.getElementById('websites').className = 'notactive';
				var xmlhttp = new XMLHttpRequest();
				xmlhttp.onreadystatechange = function()
				{
					if (this.readyState == 4 && this.status == 200)
					{
						document.getElementById('content').innerHTML = this.responseText;
						if (contentname == 'kontakt' || contentname == 'hilfe' || contentname == 'impressum')
						{
							document.getElementById('info').className = 'active';
						}
						else
						{
							document.getElementById(contentname).className = 'active';
						}
					}
				};
				xmlhttp.open('POST', contentname + 'page.php', true);
				xmlhttp.send();
			}
			if (document.getElementById('info').className == 'active')
			{
				document.getElementById('dropdown-icon').src = "/ressource/images/nydoo-dropdown-icon-black.png";
			}
			else
			{
				document.getElementById('dropdown-icon').src = "/ressource/images/nydoo-dropdown-icon-yellow.png";
			}
		}
		window.onload = change_content;
	</script>
</head>
<header>
	<ul id="mainnavigation">
		<li id="mainlist" class="dropdown"><a id="info" class="notactive" onclick="change_content(this.id);">Information<img id="dropdown-icon"
        style="width: 15px; height: 12px; float: right; margin-top: 7px; margin-right: 20px;" src="/ressource/images/nydoo-dropdown-icon-yellow.png" 
        id="dropdown_icon"></a></li>
	</ul>
</header>
<body onload="change_content('login'); return false;">
<div id="content">
</div>
</body>
</html>

What I'm trying to do is changing the color from img (id="dropdown-icon") from yellow to black whenever a (id="info") has class "active". Also the other way around (class "notactive" -> change from black to yellow). Hopefully this describes it. It maybe a simple thing. But I'm getting frustrated with this issue. Let me know if I screwed it up myself :3

Thank you very much n advance.

Edited by Shinori

Share this post


Link to post
Share on other sites

if (document.getElementById(contentname).className = 'notactive')

Should be

if (document.getElementById(contentname).className == 'notactive')

The first applies the value to classname, the latter compares value.

Share this post


Link to post
Share on other sites
Quote
5 minutes ago, dsonesuk said:

if (document.getElementById(contentname).className = 'notactive')

Should be

if (document.getElementById(contentname).className == 'notactive')

The first applies the value to classname, the latter compares value.

Alright. Thanks!

I changed it to the logical Operator '==' . Still doesn't it solve my problem :/

The img src keeps being yellow all the time.

 

Share this post


Link to post
Share on other sites

You have multiple id reference on the SAME element, when there should only be one, and the the body element should contain all the html elements that will been seen on the web page, and directly follow the closing </head>  element.

Share this post


Link to post
Share on other sites

Posted (edited)

Okay, I understood the "body" part. But what do you mean by multiple reference of the same element? 

Am I only allowed to use document.getElementById() once for each element?
Sorry if my english isn't appropriate. Not my native language :/

 

Thanks a lot!

Edited by Shinori

Share this post


Link to post
Share on other sites

<img id="dropdown-icon" style="width: 15px; height: 12px; float: right; margin-top: 7px; margin-right: 20px;" src="/ressource/images/nydoo-dropdown-icon-yellow.png" id="dropdown_icon">

Share this post


Link to post
Share on other sites

Posted (edited)

19 minutes ago, dsonesuk said:

<img id="dropdown-icon" style="width: 15px; height: 12px; float: right; margin-top: 7px; margin-right: 20px;" src="/ressource/images/nydoo-dropdown-icon-yellow.png" id="dropdown_icon">

Okay. so I changed it. Still haviing the same problems:

BTW if I click id'info' twice. The img changed to black. Is there a timing problem ?

Code: 

<!DOCTYPE html>
<html lang='de'>
<head>
	<script type='text/javascript'>
		function change_content(contentname)
		{
			if (document.getElementById(contentname).className == 'notactive')
			{
				document.getElementById('login').className = 'notactive';
				document.getElementById('news').className = 'notactive';
				document.getElementById('info').className = 'notactive';
				document.getElementById('websites').className = 'notactive';
				var xmlhttp = new XMLHttpRequest();
				xmlhttp.onreadystatechange = function()
				{
					if (this.readyState == 4 && this.status == 200)
					{
						document.getElementById('content').innerHTML = this.responseText;
						if (contentname == 'kontakt' || contentname == 'hilfe' || contentname == 'impressum')
						{
							document.getElementById('info').className = 'active';
						}
						else
						{
							document.getElementById(contentname).className = 'active';
						}
					}
				};
				xmlhttp.open('POST', contentname + 'page.php', true);
				xmlhttp.send();
			}
			if (document.getElementById('info').className == 'active')
			{
				document.getElementById('dropdown-icon').src = '/ressource/images/nydoo-dropdown-icon-black.png';
			}
			else
			{
				document.getElementById('dropdown-icon').src = '/ressource/images/nydoo-dropdown-icon-yellow.png';
			}
		}
		window.onload = change_content;
	</script>
</head>
<body onload='change_content('login'); return false;'>
<header>
	<ul id='mainnavigation'>
		<li id='mainlist' class='dropdown'><a id='info' class='notactive' onclick='change_content(this.id);'>Information<img id='dropdown-icon'
        style='position: absolute; width: 15px; height: 12px; margin-right: 20px;' src='/ressource/images/nydoo-dropdown-icon-yellow.png'></a> 	
	    </li>
	</ul>
</header>
</body>
</html>

 

Edited by Shinori

Share this post


Link to post
Share on other sites

These are just small issues that will cause problems, I can't you a outright solution to fix your problem.

You have to make sure that any element id references that are referred to in the JavaScript code, actually exist before these id references are referred to.

Share this post


Link to post
Share on other sites

Eventually the time between creating and XMLhttpRequest and getting something back was the reason that class hasnt been changed correctly. Not even sure why i wrote it into the readystate-condition :D 

 

Thanks anyways. You must be irritated by such newbies like me :P 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now