this.array = undeffined

[Matej]

Hi , im building table spoiler here http://jsfiddle.net/mLjo49rk/2/ (basicly , every text get shortened to length 1 and on click it should display full text)

 

but i have problem with function longIt();

it basicly writes Cannot read property 'length' of undefined while i was working with array this.after in function shortIt,

 

any1 knows how to fix it?

[Ingolme]

There might be confusion as to what "this" is referring to because it's inside a function that could be called from any context. Here's the solution: Make an internal variable that is explicitly set to "this" when the object is created and use that variable to refer to the object.

 

You also forgot to define the variable "event", it should be the first parameter of the click event handler.

function matej(element)    var self = this; // Reference to the object    // ...    self.longIt = function() {        for (var i = 0; i < self.children.length; i++) {            self.children[i].onclick = function (e) { // Added event object. Called it "e" so it won't override global variable "event" that IE needs                e = e ? e : window.event; // Compatibility for Internet Explorer                var x=self.after.indexOf(e.target.innerHTML);                alert("!as");            }        }    }    // ...}

[Matej]

I added varriable which refer to this , but it has broken the code

http://jsfiddle.net/mLjo49rk/3/

 

// i could call self. from inside the Matej() but not inside loops and prototype

Edited October 28, 2014 by Matej

[Ingolme]

It should be safe to use the "this" keyword when you're adding a function to the prototype, it's only in the class definition where you need to have a clear reference to the object.

 

After correcting that, I still get an error because you haven't defined "event" yet.

[Matej]

got it , thanks =http://jsfiddle.net/mLjo49rk/5/ , also , the event thing function(e) is only for IE right?(IE needs to pass it or smt) so why didnt it work in chrome ? i have never had problem with it before.

[Ingolme]

A global variable called "event" only exists in IE. Every other browser expects a function parameter: function(eventObject) {

[Matej]

Thanks , i thought i was vice verse