If/elseif Help Needed Please Options

[paulmo]

in the example below, text searches are not being filtered through each if/else statement, so that, for example, when "good dog" is searched against db, i'm getting echoes from both the echo_light (echo) and echo_dark (echod) tables, when all that should be matching and echoed would be the echo_light table entry (since 'good' is in user string in this example). if i searched "bad dog" all i'd want to echo would be matched row from the echo_dark(echod) table, etc.

any help greatly appreciated. justsomeguy wrote/helped me with this last winter and i'm just getting back to it. Thanks!

CODE

if (in_array(strtolower($word), array('you'))) {
echo "You seem to be addressing me, {$post_name}</br></br>";
}
elseif (in_array(strtolower($word), array('great', 'good', 'fun', 'wonderful', 'beautiful', 'love', 'happy', 'exciting', 'joy',))) {
echo "You're exuding positive energy. </br></br>";
}
$sql = ' ';
$sql = "SELECT a.id, a.subject, b.echo FROM terms AS a, echo_light AS b WHERE a.id=b.id AND (a.subject LIKE '%$word%' OR a.subject LIKE '%$word%')";
$result = mysql_query($sql) or die (mysql_error ());
$n=0;
while($row = mysql_fetch_assoc($result))
{
$n++;
echo nl2br(stripslashes($row['echo']));
    echo "<br>";
}
if (in_array(strtolower($word), array('desperate','anxious', 'panic', 'distressed', 'negative', 'stress', 'stressed', 'dark', 'sad', 'depressed', 'hurt', 'bleak', 'gloom', 'bad', 'lonely', 'alone', 'alien',))) {
echo "Your tone seems grim or distressing, {$post_name}.";
}
$sqld = ' ';
$sqld = "SELECT a.id, a.subject, b.echod FROM terms AS a, echo_dark AS b WHERE a.id=b.id AND (a.subject LIKE '%$word%' OR a.subject LIKE '%$word%')";
$result = mysql_query($sqld) or die (mysql_error ());
$n=0;
while($row = mysql_fetch_assoc($result))
{
$n++;
echo nl2br(stripslashes($row['echod']));
    echo "<br>";
}

[justsomeguy]

Wow, has it been that long?

Strip out the excess code and just look at the structure. You'll notice that you always run the query on the second table. In fact, you always run the query on the first table also. The if statements are only printing a line of text, not controlling the database work. This is what your code structure looks like:

CODE

if (word is you)
{
  print personal note
}
elseif (word is "light")
{
  print "light" note
}

run "light" database query, print results

if (word is "dark")
{
  print "dark" note
}

run "dark" database query, print results

Notice how the 2 database parts aren't part of the if structure. You probably want a structure like this:

CODE

if (word is you)
{
  print personal note
}
elseif (word is "light")
{
  print "light" note
  run "light" database query, print results
}
elseif (word is "dark")
{
  print "dark" note
  run "dark" database query, print results
}

Also, your queries contain this:

a.subject LIKE '%$word%' OR a.subject LIKE '%$word%'

That's the same condition written twice, you can leave out the OR and just write that condition once.

[paulmo]

Wow, has it been that long?

yes indeed, hope you are doing well. i seem to learn in a compulsive fashion.

You'll notice that you always run the query on the second table. In fact, you always run the query on the first table also.

yes, user array match gets sent to a.id and a.subject first, then those id's, depending on light or dark array match, get sent to either echo or echod (dark) table, where the matching id row is echoed to user.

a.subject LIKE '%$word%' OR a.subject LIKE '%$word%'

ok, reduced this to a.subject LIKE '%$word%'

have also deleted extra { }s around each database part so structure matches your suggestion.

now, only the personal 'you' message is working. not getting any database interaction now, whereas before i was getting too much (echoing both echo and echod when only one should be echoed). i know this isn't much to go on. if you can suggest, thanks, if not i'll try to troubleshoot more.

[justsomeguy]

Can you post the code you have now?

[paulmo]

CODE

if (in_array(strtolower($word), array('you')))
{
echo "You seem to be addressing me, {$post_name}. </br></br>";
}
elseif (in_array(strtolower($word), array('great', 'good', 'fun', 'wonderful', 'beautiful', 'love', 'happy', 'exciting', 'joy',)))
{
echo "You're exuding positive energy. </br></br>";

$sql = ' ';
$sql = "SELECT a.id, a.subject, b.echo FROM terms AS a, echo_light AS b WHERE a.id=b.id AND (a.subject LIKE '%$word%')";
$result = mysql_query($sql) or die (mysql_error ());
$n=0;
while($row = mysql_fetch_assoc($result))

$n++;
echo nl2br(stripslashes($row['echo']));
    echo "<br>";
}
elseif (in_array(strtolower($word), array('desperate','anxious', 'panic', 'distressed', 'negative', 'stress', 'stressed', 'dark', 'sad', 'depressed', 'hurt', 'bleak', 'gloom', 'bad', 'lonely', 'alone', 'alien',)))
{
echo "Your tone seems grim or distressing, {$post_name}.";

$sqld = ' ';
$sqld = "SELECT a.id, a.subject, b.echod FROM terms AS a, echo_dark AS b WHERE a.id=b.id AND (a.subject LIKE '%$word%')";
$result = mysql_query($sqld) or die (mysql_error ());
$n=0;
while($row = mysql_fetch_assoc($result))

$n++;
echo nl2br(stripslashes($row['echod']));
    echo "<br>";
}

gracias

[justsomeguy]

You still need the brackets for the while loops, as it is now it's only looping over the first line ($n++), so it would only display the last row in each result.

[paulmo]

thanks jsg, i'll be experimenting this weekend and will report back here. regards, paulmo