Jump to content
nickc

Small screen menu not collapsing after click

Recommended Posts

Hello

 

I have built a one page website based on this template - http://www.w3schools.com/w3css/tryw3css_templates_website.htm

 

When viewed a smartphone screen the smallscreen navbar does not collapse after clicking a link and I therefore have to toggle the nav button manually.

 

I have created a workaround in order for the site to function as desired which can be found here - http://www.davidclarkandco.co.uk/index.html - but ideally I simply wish to use a single page and have the menu to collapse on click.

 

Thanks in advance for advice/help.

Share this post


Link to post
Share on other sites

You can add a click event to all the links within the menu to make the menu collapse.

Share this post


Link to post
Share on other sites

You can add a click event to all the links within the menu to make the menu collapse.

 

Thanks. Any chance of a pointer as to how I might implement that?

Share this post


Link to post
Share on other sites

Have you learned Javascript yet?

Share this post


Link to post
Share on other sites

Have you learned Javascript yet?

 

I have done some in the past and am aware of onclick events. If it can be done that way I'm happy to go with that. Just wasn't sure it was possible with W3.CSS as all the solutions I've found so far relate to bootstrap.

Share this post


Link to post
Share on other sites

Unlike Bootstrap, W3.CSS does not use any Javascript. If you look at the example page, what they've done is add Javascript to it. If you look at the bottom of the page, they've defined a function called openNav().

 

What you can do is go through each of the links and have them call openNav when clicked.

// Get a list of links
var links = document.querySelectorAll(".w3-navbar .w3-hide-small > a");

// Loop through the links to add the event listener
for(var i = 0; i < links.length; i++) {
  links[i].addEventListener("click", openNav, false);
}

Share this post


Link to post
Share on other sites

 

Unlike Bootstrap, W3.CSS does not use any Javascript. If you look at the example page, what they've done is add Javascript to it. If you look at the bottom of the page, they've defined a function called openNav().

 

What you can do is go through each of the links and have them call openNav when clicked.

// Get a list of links
var links = document.querySelectorAll(".w3-navbar .w3-hide-small > a");

// Loop through the links to add the event listener
for(var i = 0; i < links.length; i++) {
  links[i].addEventListener("click", openNav, false);
}

 

Fabulous. It works. Thanks so much!

Share this post


Link to post
Share on other sites

Unlike Bootstrap, W3.CSS does not use any Javascript.

Err, yes! It does, massively so, difference, bootstrap is unobtrusive, w3.css is all inline to elements and page itself.

Share this post


Link to post
Share on other sites

That's not part of the W3.CSS framework, they just add Javascript onto the page in the examples specifically because it's not included in the framework.

Share this post


Link to post
Share on other sites

I think the point they're trying to get with these examples is that if you want something done with Javascript you have to write the Javascript yourself, the framework is a purely CSS framework intended just for presentation and not behavior.

Share this post


Link to post
Share on other sites

To claim its just css is a stupid statement, as mentioned most of its examples would not work without them adding JavaScript specifically for there w3css examples.

 

Take for instance, there many templates, why include javscript for templates, you have html with w3css classes, and css, just add your own JavaScript so it will work as w3css intended. Going by that statement every website is just a css framework for presentational, with just our own added JavaScript to make it behavioral.

Share this post


Link to post
Share on other sites

The difference between W3.CSS and Bootstrap is that Bootstrap comes with a bootstrap.js file while W3.CSS has no associated JS file in the framework. You just include w3.css in your website and everything else has to be added manually on top.

Share this post


Link to post
Share on other sites

So just because they can't be bothered to add all THEIR JavaScript code into one JavaScript file, to make THEIR template behavioral, its still only a css framework, no! I really don't think so.

Share this post


Link to post
Share on other sites

Hi, I have the same problem as Nickc and I have tried to solve it as Ingolme has offered. Unfortunately I failed. Please tell me where the mistake is. I would be very thankful for help. Below is the script

<div class="w3-padding-0 w3-large w3-text-grey" style="font-weight:bold">
    <a onclick="myAccFunc()" class="w3-button w3-block w3-white w3-left-align"> Наши проекты <i class="fa fa-caret-down"></i></a>
    <div id="demoAcc" href="javascript:void(0)" class="w3-bar-block w3-hide w3-padding-large w3-medium">
      <a href="http://тетрадкадружбы.заботадетям.рф" class="w3-bar-item w3-button w3-light-grey"><i class="fa fa-caret-right w3-margin-right"></i>Тетрадка дружбы</a>
      <a href="http://стритбол.заботадетям.рф" class="w3-bar-item w3-button w3-light-grey"><i class="fa fa-caret-right w3-margin-right"></i>Стритбол</a>
      <a href="http://даридобро.заботадетям.рф" class="w3-bar-item w3-button w3-light-grey"><i class="fa fa-caret-right w3-margin-right"></i>Дари добро</a>
      <a href="http://домребенка.заботадетям.рф" class="w3-bar-item w3-button w3-light-grey"><i class="fa fa-caret-right w3-margin-right"></i>Дом ребенка</a>
      <a href="http://времяцветов.заботадетям.рф" class="w3-bar-item w3-button w3-light-grey"><i class="fa fa-caret-right w3-margin-right"></i>Время цветов</a>
    </div>
    <a href="http://помочь.заботадетям.рф" class="w3-bar-item w3-button">Как помочь</a>
    <div id="navDemo" href="javascript:void(0)">
    <a onclick="openNav()" href="#about" class="w3-bar-item w3-button">О нашем фонде</a>
    <a onclick="openNav()" href="#mission" class="w3-bar-item w3-button">Миссия фонда</a>
    <a onclick="openNav()" href="#docs" class="w3-bar-item w3-button">Учредительные документы</a>   
    <a onclick="openNav()" href="#team" class="w3-bar-item w3-button">Координаторы</a>
    <a onclick="openNav()" href="#rewards" class="w3-bar-item w3-button">Благодарности</a>
    <a onclick="openNav()" href="#contact" class="w3-bar-item w3-button">Контакты</a>
    </div>
  </div>

 

<script>
// Accordion
function myAccFunc() {
    var x = document.getElementById("demoAcc");
    if (x.className.indexOf("w3-show") == -1) {
        x.className += " w3-show";
    } else {
        x.className = x.className.replace(" w3-show", "");
    }
}
// Script to open and close sidebar
function w3_open() {
    document.getElementById("mySidebar").style.display = "block";
    document.getElementById("myOverlay").style.display = "block";
}
 
function w3_close() {
    document.getElementById("mySidebar").style.display = "none";
    document.getElementById("myOverlay").style.display = "none";
}
// Used to toggle the menu on smaller screens when clicking on the menu button
function openNav() {
    var x = document.getElementById("navDemo");
    if (x.className.indexOf("w3-show") == -1) {
        x.className += " w3-show";
    } else {
        x.className = x.className.replace(" w3-show", "");
    }
}
</script>

Share this post


Link to post
Share on other sites

(1) Div element cannot use href attribute, they are only for anchor 'a' elements.

(2)  var x = document.getElementById("navDemo");  assign a element with id ref 'navDemo' ie <div id="navDemo" href="javascript:void(0)"> (with invalid href attribute) to variable 'x'

then it checks this specific element classes?

if (x.className.indexOf("w3-show") == -1) {
        x.className += " w3-show";
    } else {
        x.className = x.className.replace(" w3-show", "");
    }

but! can you see the problem here? there are no classes for this element.

Share this post


Link to post
Share on other sites
On ‎20‎.‎09‎.‎2016 at 11:38 PM, nickc said:

Thank you, I have corrected the Div element and replaced href attribute to the <a> line above. What about onclick attributes? Shall I also replace script to the one below? :

// Get a list of links

var links = document.querySelectorAll(".w3-navbar .w3-hide-small > a");

// Loop through the links to add the event listener

for(var i = 0; i < links.length; i++) { links[i].addEventListener("click", openNav, false);

}

 

 

Edited by Roman Heidemann

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...

×
×
  • Create New...