Jump to content
Sign in to follow this  
Tatsu

How to set a countdown in realtime in HTML/JavaScript

Recommended Posts

Hello, I want to do a countdown and put it in my website. I did a countdown but I have a problem, when I launch it, the seconds are freezing they are not anymore running... So the countdown is not in realtime anymore... I have to refresh in order to see the countdown running.
Here is what I did:

<div id="after">
    <span id="dhour"></span>:<span id="dmin"></span>:<span id="dsec"></span>
</div>
<div id="count2">Texte à afficher</div>
   
<div class="numbers" id="dday" hidden="true"></div>
<script>
var ladate = new Date("<?php
echo gmdate("Y-m-d\TH:i:s\Z");?>");
var year=ladate.getFullYear();
var month=ladate.getMonth()+1;
var day=ladate.getDate();
var hour=14;
var minute=20;
var tz=0;
 
var montharray=new Array("Jan","Feb","Mar","Apr","May","Jun","Jul","Aug","Sep","Oct","Nov","Dec");
 
function countdown(yr,m,d,hr,min){
theyear=yr;themonth=m;theday=d;thehour=hr;theminute=min;
var today= new Date("<?php
echo gmdate("Y-m-d\TH:i:s\Z");?>");
var todayy=today.getYear();
if (todayy < 1000) {todayy+=1900; }
 
var todaym=today.getMonth();
var todayd=today.getDate();
var todayh=today.getHours();
var todaymin=today.getMinutes();
var todaysec=today.getSeconds();
var todaystring1=montharray[todaym]+" "+todayd+", "+todayy+" "+todayh+":"+todaymin+":"+todaysec;
var todaystring=Date.parse(todaystring1)+(tz*1000*60*60);
var futurestring1=(montharray[m-1]+" "+d+", "+yr+" "+hr+":"+min);
var futurestring=Date.parse(futurestring1)-(today.getTimezoneOffset()*(1000*60));
var dd=futurestring-todaystring;
var dday=Math.floor(dd/(60*60*1000*24)*1);
var dhour=Math.floor((dd%(60*60*1000*24))/(60*60*1000)*1);
var dmin=Math.floor(((dd%(60*60*1000*24))%(60*60*1000))/(60*1000)*1);
var dsec=Math.floor((((dd%(60*60*1000*24))%(60*60*1000))%(60*1000))/1000*1);
 
if(dday<=0&&dhour<=0&&dmin<=0&&dsec<=0){
document.getElementById('count2').style.display="inline";
document.getElementById('after').style.display="none";
document.getElementById('dday').style.display="none";
document.getElementById('dhour').style.display="none";
document.getElementById('dmin').style.display="none";
document.getElementById('dsec').style.display="none";
document.getElementById('days').style.display="none";
document.getElementById('hours').style.display="none";
document.getElementById('minutes').style.display="none";
document.getElementById('seconds').style.display="none";
return;}else {
document.getElementById('count2').style.display="none";
document.getElementById('dday').innerHTML=dday;
document.getElementById('dhour').innerHTML=dhour;
document.getElementById('dmin').innerHTML=dmin;
document.getElementById('dsec').innerHTML=dsec;
window.location.reload();
setTimeout("countdown(theyear,themonth,theday,thehour,theminute)",1000);}}
 
countdown(year,month,day,hour,minute);
</script>

Thank you.

Share this post


Link to post
Share on other sites

Countdown to what? This looks like quite a mess if all it does is provide a countdown to a specific date/time.

 

Have you used the browser console to check for errors?

Share this post


Link to post
Share on other sites

If you properly indent your code, you'll find that your code keeps reloading the window before it gets to the part of the code that counts down.

 

The offending line is window.location.reload();

function countdown(yr,m,d,hr,min){
  theyear=yr;themonth=m;theday=d;thehour=hr;theminute=min;

  // ...
   
  var todaym=today.getMonth();
  // ...
   
  if(dday<=0&&dhour<=0&&dmin<=0&&dsec<=0){
    // ...
    return;
  } else {
    // ...
    window.location.reload();
    setTimeout("countdown(theyear,themonth,theday,thehour,theminute)",1000);
  }
}

Aside from that, this code looks a little more complicated than it needs to be.

Since you have global variables, don't bother passing parameters to the countdown function. Then you can simplify it like this:

function countdown() {
 // ...
 // ...
  setTimeout(countdown, 1000);
}

Using a string in setTimeout and setInterval is inefficient.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×