Jump to content
  • Announcements

    • boen_robot

      Guidelines and Netiquette   03/28/2017

      Posting Problems:   Having problems posting your topic? Read through this: To join, you agree to our terms and conditions and fill out and submit a registration form. An activation email will be sent to your email adress, so you'll need to verify your account. After that the account has to be validated by one of the moderators. This will mean that it can take up to a day to be activated. A couple of things to remember to ensure approval: Don't use an email address in one of those $2 four character .com domains eg. xyds.com. These will be deleted and the domain added to the banned list. Don't use an email address that is within a domain with a bad reputation for spam. A Google search is run on every email address and email domain. Don't sign up with an email address that doesn't exist, doesn't work or requires the sender to answer a quiz before their email can get to you. Put your country and or state and city in the signup form. Blank forms will go to the botton of the "to do" list. And make sure that your email address and your country match, saying you're from Alabama and using a .ru email address is not going to get you activated. After a membership is activated the first few posts will be monitored. Posting spam or unapproved topics described in the agreement results in an immediate ban. The email provider and the IP addresses associated with the account will be banned and all posts will be deleted. These strict measures have been deemed necessary to hinder spam. Sorry for any inconvenience this causes, but it's not liable to change. If, after reading this, you still can't post and don't understand why, contact one of the Moderators listed here.   Topic Guidelines   Including the following information can expedite an accurate response from board members: Must be a Specific Problem or Question related to web design and development Include Code in Question (wrap with   for small blocks of code and for longer blocks   ) Include Code Author Include Extra Notes/Modifications/Attempts Include web link to page/file when possible Content Guidelines   You may not post, upload, link to, or email any Content that contains, promotes, gives instruction about, or provides prohibited Content. Prohibited Content includes any Content that breaks any local, state, county, national or international law. Prohibited Content also includes: No direct or indirect advertising or websites, forums, products, services No hijacking of posts (do not post your question in someone elses) Content that infringes upon any rights [ex. MP3s and ROMs] (including, but not limited to, copyrights and trademarks) Abusive, threatening, defamatory, racist, or obscene Viruses or any other harmful computer software False Information or libel Spam, chain letters, or Pyramid schemes Gambling or Illicit drugs Terrorism Hacking or cheating for internet/online games Warez, Roms, CD-Keys, Cracks, Passwords, or Serial Numbers Pornography, nudity, or sexual material of any kind Excessive profanity Invasive of privacy or impersonation of any person/entity Hacking materials or information Posting Tips   There are more BBcodes than there are buttons for on the reply menu. To get the full list, click "BB Code Help" underneath the clickable smilie face menu. Use   for small snippets of code Use   for lengthy snippets of code Use   if your snippet is HTML (optional) Use   if your snippet is SQL (optional) Rules of Conduct   Be nice. There's no need for calling someone stupid if they ask an 'easy' question. Keep your avatars and signatures absolutely child friendly. We have a younger audience on this forum. Keep your language appropriate for the same reason above. Do not PM moderators for help on the forum. Post on the topic, or create a new one.   Spam:   Recently, as you have all without doubt noticed, we have had lots of spam and advertisement on the forum. Therefore, we'd like to alert you as to what to do when you have found any of the aforementioned annoying messages: it. Immediately. Give a clear reason, please, if the advertising is not evident. DO NOT POST! Report, let the post stay as is, and we will get to it, meanwhile if you continue to post as normal in the other threads, it won't be on the top so long. Refrain from PMing the member. This won't help at all, as they are most likely spambots anyway. Thank you.       Images in signatures:   After thinking of users on dial-up, we have decided to enforce the following rules regarding signatures. Please pay heed to them. Respecting these rules is respecting the members on this forum with dial-up. Signature rules: No animated images AT ALL. No matter the amount of animation. Maximum image widthxheight: 300x150 Maximum image (file) size: 15kb Use calm colors. Do not use highly contrasting images in your signature, as this can get really annoying when seeing several posts from one member in the same thread. The same prohibited content goes for images as for posts. Lastly, use common sense. No lengthy signatures please. Save us some scrolling. Thank you.       Links in signatures:   Please understand that w3schools.com only exists because of voluntary work and is barely supported by the advertising littered throughout the tutorials and the forum. So, please, stop advertising other sites. DO not post links that drive traffic away from the w3schools domain - especially to a site that offers similar if not identical information. Please help support the site by keeping individuals on it. Thank you. Here are some guidelines as to what you can put in your signature: w3schools links --> allowed w3.org links --> allowed browser links --> allowed html editor links --> allowed personal sites --> allowed tutorial sites competing with w3schools --> NOT allowed sites completely irrelevant to webprogramming and this forum --> NOT allowed   Thanks for understanding, and for taking the time to read this. ~W3Schools Modstaff~
Sign in to follow this  
Douglas Henderson

Help with this method

Recommended Posts

Hi, I am in need of help with this tic tac toe game. I have been working on it longer than I care to admit. I am trying to get it to compile correctly. I am working on the winorTie method and been having trouble figure out what code to insert. I understand that I need to write code that goes through the game board row by row and counts how many X's or O's have been marked. Yet every time I've inserted code it doesn't compile correctly. Right now I have the foundation for the if statement but unsure about the code.

 

Whenever I compile I get the below in the output section.

 

| | | |

------

| | | |
------

| | | |
------


-0's turn-

 

 

When compiled correctly it is supposed to look like this in the output section.

 

||||
-------
||||
-------
||||
-------
--O’s turn--
|O| | |
-------
||||
-------
||||
-------
--X’s turn--
|O|X| |
------- |||| ------- |||| -------

--O’s turn--
|O|X| |
-------
| |O| |
-------
||||
-------
--X’s turn--
|O|X| |
-------
| |O| |
-------
|X| | |
______
—O’s turn—
|O|X| |
-------
| |O| |
-------
|X| |O|
O wins!

 

 

 

Here is my current code..

/* * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
package tictactoegame;


/**
 *
 * @author Doug Henderson
 */
public class tictactoegame {
    
    static int [] [] gameboard;
    static final int EMPTY = 0;
    static final int NOUGHT = -1;
    static final int CROSS = 1;
    
    static void set (int val, int row)
            throws IllegalArgumentException {
        int col = 0;
        if (gameboard[row] [col]  == EMPTY)
                gameboard[row] [col] = val;
        else throw new
            IllegalArgumentException("Player already there!");
    }
    
    static void displayBoard () {
        for (int[] gameboard1 : gameboard) {
            System.out.print("|");
            for (int c = 0; c < gameboard1.length; c++) {
                switch (gameboard1[c]) {
                    case NOUGHT:
                        System.out.print("0");
                        break;
                    case CROSS:
                        System.out.print("X");
                        break;
                    default:           //Empty
                        System.out.print(" ");
                }
                System.out.print("|");
            }
            System.out.println("\n------\n");
        }
    }
    static void createBoard(int rows, int cols) {
        gameboard = new int [rows] [cols];
    }
    
    static int winOrTie() {
    if (); 
           return ;
    else if ();
           return ;
    else if ();{    
           return ;
    else {
           return ;
                               
    }
           
  
    /**
     * @param args the command line arguments
     */    /**
     * @param args the command line arguments
     */
     
     public static void main(String[] args)  {
        createBoard(3,3);
        int turn = 0;
        int playerVal;
        int outcome;
        java.util.Scanner scan = new
            java.util.Scanner(System.in);
        do {
            displayBoard();
            playerVal = (turn % 2 == 0)? NOUGHT : CROSS;
            if (playerVal == NOUGHT) {
                System.out.println ("\n-0's turn-");
            } else {
                System.out.println("\n-X's turn-");
                }
            System.out.print("Enter row and Column:");
            try {
                set(playerVal, scan.nextInt());
            } catch (IllegalArgumentException ex)
            {System.err.println(ex);}
            turn ++;
            outcome = winOrTie();
        } while ( outcome == -2 );
        displayBoard();
        switch (outcome) {
            case NOUGHT:
                System.out.println("0 wins!");
                break;
            case CROSS:
                System.out.println("X wins!");
                break;
            case 0:
                System.out.println("Tie.");
                break;
            }
     }
     
}
 
Edited by Douglas Henderson

Share this post


Link to post
Share on other sites
justsomeguy    942

The skeleton you have for the if structure isn't correct, you don't have enough brackets and you have too many semicolons. Look at the main method to see how to format an if/else structure.

Share this post


Link to post
Share on other sites
davej    244

This code is almost too horrible to fix. Are you teaching yourself Java?

 

Do you really want a variable-sized board? That requires a fair amount of additional complexity.

Share this post


Link to post
Share on other sites
Ingolme    794

I would say that a variable size board is good for learning. Regardless of the board size you have to go through rows, columns and two diagonals.

Share this post


Link to post
Share on other sites
davej    244

Main should be simple and provide an outline of what you are doing. In my version of your program it looks like this...

public static void main(String[] args)  {

        gameboard = new int[SIZE][SIZE]; // board must be square
        int turn = 0;
        int outcome;
        displayBoard();
         
        do {
            turn = promptUser(turn);
            displayBoard();
            outcome = winOrTie();
            
        } while ( outcome == -2 );
        
        displayResults(outcome);
        
    }// end of main

Share this post


Link to post
Share on other sites

This is a small assignment I have been given. They have given me most of the code and I have to figure out the rest. My winorTie method is what I have to figure out. So yes I am pretty much teaching myself.

Modified it a bit adding brackets. Do I still have too many semicolons? I am trying to figure out what code to put in though. It is a work in progress.

Part of the directions...

The variable gameboard is a two-dimensional int array. Think of it as a table with rows and columns, and cells can be empty (0) or contain a nought (–1) or cross (1). The constants EMPTY, NOUGHT, and CROSS will simplify your code.

Define the winOrTie method. Check first for a win with rows and columns and then diagonally. Finally, check to see if there are any empty cells without a cross or nought.


static int winOrTie() {
   if ( ( ) ) {
      return CROSS;
} else if ( ( ) ) {
      return NOUGHT;
} else if ( ( ) ) {
     return
} else {
     return
}
 
}
Edited by Douglas Henderson

Share this post


Link to post
Share on other sites

The skeleton you have for the if structure isn't correct, you don't have enough brackets and you have too many semicolons. Look at the main method to see how to format an if/else structure.

 

 

Thank you, so the if/else structure in the below main method is the way to go?

displayBoard();
            playerVal = (turn % 2 == 0)? NOUGHT : CROSS;
            if (playerVal == NOUGHT) {
                System.out.println ("\n-0's turn-");
            } else {
                System.out.println("\n-X's turn-");
                }
            System.out.print("Enter row and Column:");
            try {
                set(playerVal, scan.nextInt());
            } catch (IllegalArgumentException ex)
            {System.err.println(ex);}
            turn ++;
            outcome = winOrTie();
        } while ( outcome == -2 );
        displayBoard();

Share this post


Link to post
Share on other sites
davej    244

 

This is a small assignment I have been given. They have given me most of the code and I have to figure out the rest.

 

 

Given by who? This is terrible code. Don't learn to code like this. There are many books and tutorials available.

 

Begin with a main() something like this...

public static void main(String[] args)  {

        gameboard = new int[SIZE][SIZE]; // board must be square
        int outcome;
         
        do {
            displayBoard();
            promptUser();
            outcome = winOrTie();
            
        } while ( outcome == INCOMPLETE );
        
        displayResults(outcome);
        
    }// end of main

Share this post


Link to post
Share on other sites
davej    244
static int winOrTie() {
   if ( ( ) ) {
      return CROSS;
} else if ( ( ) ) {
      return NOUGHT;
} else if ( ( ) ) {
     return
} else {
     return
}
 
}

This approach can only be used if the board is a fixed size. If you know it is always a 3 x 3 board then it is easy to formulate an if structure. Something simple like this could work...

if(gameboard[0][0] + gameboard[0][1] + gameboard[0][2] == 3*NOUGHT){return NOUGHT;}
if(gameboard[1][0] + gameboard[1][1] + gameboard[1][2] == 3*NOUGHT){return NOUGHT;}
if(gameboard[2][0] + gameboard[2][1] + gameboard[2][2] == 3*NOUGHT){return NOUGHT;}

if(gameboard[0][0] + gameboard[1][0] + gameboard[2][0] == 3*NOUGHT){return NOUGHT;}
if(gameboard[0][1] + gameboard[1][1] + gameboard[2][1] == 3*NOUGHT){return NOUGHT;}
if(gameboard[0][2] + gameboard[1][2] + gameboard[2][2] == 3*NOUGHT){return NOUGHT;}

if(gameboard[0][0] + gameboard[1][1] + gameboard[2][2] == 3*NOUGHT){return NOUGHT;}
if(gameboard[0][2] + gameboard[1][1] + gameboard[2][0] == 3*NOUGHT){return NOUGHT;}

if(gameboard[0][0] + gameboard[0][1] + gameboard[0][2] == 3*CROSS){return CROSS;}
if(gameboard[1][0] + gameboard[1][1] + gameboard[1][2] == 3*CROSS){return CROSS;}
if(gameboard[2][0] + gameboard[2][1] + gameboard[2][2] == 3*CROSS){return CROSS;}

if(gameboard[0][0] + gameboard[1][0] + gameboard[2][0] == 3*CROSS){return CROSS;}
if(gameboard[0][1] + gameboard[1][1] + gameboard[2][1] == 3*CROSS){return CROSS;}
if(gameboard[0][2] + gameboard[1][2] + gameboard[2][2] == 3*CROSS){return CROSS;}

if(gameboard[0][0] + gameboard[1][1] + gameboard[2][2] == 3*CROSS){return CROSS;}
if(gameboard[0][2] + gameboard[1][1] + gameboard[2][0] == 3*CROSS){return CROSS;}

if(turn < 9){
    return INCOMPLETE;
}else{
    return TIE;
}


Share this post


Link to post
Share on other sites

 

 

Given by who? This is terrible code. Don't learn to code like this. There are many books and tutorials available.

 

Begin with a main() something like this...

public static void main(String[] args)  {

        gameboard = new int[SIZE][SIZE]; // board must be square
        int outcome;
         
        do {
            displayBoard();
            promptUser();
            outcome = winOrTie();
            
        } while ( outcome == INCOMPLETE );
        
        displayResults(outcome);
        
    }// end of main

 

 

It has been given by my school.

Share this post


Link to post
Share on other sites

Quick question, where did you get the number 9 from and 'incomplete'? Also should I also put in 'EMPTY' in with the code...example..

if(gameboard[0][0] + gameboard[0][1] + gameboard[0][2] == 3*EMPTY){return EMPTY;}
if(gameboard[1][0] + gameboard[1][1] + gameboard[1][2] == 3*EMPTY){return EMPTY;}
if(gameboard[2][0] + gameboard[2][1] + gameboard[2][2] == 3*EMPTY){return EMPTY;}

Thank you

Share this post


Link to post
Share on other sites
Ingolme    794

There can be no more than 9 turns on the board, if nobody has won and less than 9 turns have passed then the game is still in progress.

INCOMPLETE would be a constant meaning the same thing as -2 did in your previous code.

 

There's no need to test for empty, since having three empty slots in a row doesn't end the game.

Share this post


Link to post
Share on other sites
davej    244

There are almost always several different ways to approach any programming problem, and that is true here, but you first need to logically understand what you are trying to accomplish, and usually you also want to think of a few simple "test cases" to help you verify your thinking and your code.

 

Your above question makes me wonder if you logically understand what the code needs to do? How would you write code to detect that at least one square on the board is empty? You can use pencil and paper to help you reason through the problem. My code sample uses a global "turn" variable but you could also test the values on the gameboard. How would you do that?

 

Also what are you using to write this code? Eclipse? Netbeans? Whatever it is you should learn to use the debugger so that you can single-step through your code.

 

I would also suggest that you sign up here...

 

https://www.hackerrank.com/

 

...and try working the introductory Java practice problems.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×