Jump to content
  • Announcements

    • boen_robot

      Guidelines and Netiquette   03/28/2017

      Posting Problems:   Having problems posting your topic? Read through this: To join, you agree to our terms and conditions and fill out and submit a registration form. An activation email will be sent to your email adress, so you'll need to verify your account. After that the account has to be validated by one of the moderators. This will mean that it can take up to a day to be activated. A couple of things to remember to ensure approval: Don't use an email address in one of those $2 four character .com domains eg. xyds.com. These will be deleted and the domain added to the banned list. Don't use an email address that is within a domain with a bad reputation for spam. A Google search is run on every email address and email domain. Don't sign up with an email address that doesn't exist, doesn't work or requires the sender to answer a quiz before their email can get to you. Put your country and or state and city in the signup form. Blank forms will go to the botton of the "to do" list. And make sure that your email address and your country match, saying you're from Alabama and using a .ru email address is not going to get you activated. After a membership is activated the first few posts will be monitored. Posting spam or unapproved topics described in the agreement results in an immediate ban. The email provider and the IP addresses associated with the account will be banned and all posts will be deleted. These strict measures have been deemed necessary to hinder spam. Sorry for any inconvenience this causes, but it's not liable to change. If, after reading this, you still can't post and don't understand why, contact one of the Moderators listed here.   Topic Guidelines   Including the following information can expedite an accurate response from board members: Must be a Specific Problem or Question related to web design and development Include Code in Question (wrap with   for small blocks of code and for longer blocks   ) Include Code Author Include Extra Notes/Modifications/Attempts Include web link to page/file when possible Content Guidelines   You may not post, upload, link to, or email any Content that contains, promotes, gives instruction about, or provides prohibited Content. Prohibited Content includes any Content that breaks any local, state, county, national or international law. Prohibited Content also includes: No direct or indirect advertising or websites, forums, products, services No hijacking of posts (do not post your question in someone elses) Content that infringes upon any rights [ex. MP3s and ROMs] (including, but not limited to, copyrights and trademarks) Abusive, threatening, defamatory, racist, or obscene Viruses or any other harmful computer software False Information or libel Spam, chain letters, or Pyramid schemes Gambling or Illicit drugs Terrorism Hacking or cheating for internet/online games Warez, Roms, CD-Keys, Cracks, Passwords, or Serial Numbers Pornography, nudity, or sexual material of any kind Excessive profanity Invasive of privacy or impersonation of any person/entity Hacking materials or information Posting Tips   There are more BBcodes than there are buttons for on the reply menu. To get the full list, click "BB Code Help" underneath the clickable smilie face menu. Use   for small snippets of code Use   for lengthy snippets of code Use   if your snippet is HTML (optional) Use   if your snippet is SQL (optional) Rules of Conduct   Be nice. There's no need for calling someone stupid if they ask an 'easy' question. Keep your avatars and signatures absolutely child friendly. We have a younger audience on this forum. Keep your language appropriate for the same reason above. Do not PM moderators for help on the forum. Post on the topic, or create a new one.   Spam:   Recently, as you have all without doubt noticed, we have had lots of spam and advertisement on the forum. Therefore, we'd like to alert you as to what to do when you have found any of the aforementioned annoying messages: it. Immediately. Give a clear reason, please, if the advertising is not evident. DO NOT POST! Report, let the post stay as is, and we will get to it, meanwhile if you continue to post as normal in the other threads, it won't be on the top so long. Refrain from PMing the member. This won't help at all, as they are most likely spambots anyway. Thank you.       Images in signatures:   After thinking of users on dial-up, we have decided to enforce the following rules regarding signatures. Please pay heed to them. Respecting these rules is respecting the members on this forum with dial-up. Signature rules: No animated images AT ALL. No matter the amount of animation. Maximum image widthxheight: 300x150 Maximum image (file) size: 15kb Use calm colors. Do not use highly contrasting images in your signature, as this can get really annoying when seeing several posts from one member in the same thread. The same prohibited content goes for images as for posts. Lastly, use common sense. No lengthy signatures please. Save us some scrolling. Thank you.       Links in signatures:   Please understand that w3schools.com only exists because of voluntary work and is barely supported by the advertising littered throughout the tutorials and the forum. So, please, stop advertising other sites. DO not post links that drive traffic away from the w3schools domain - especially to a site that offers similar if not identical information. Please help support the site by keeping individuals on it. Thank you. Here are some guidelines as to what you can put in your signature: w3schools links --> allowed w3.org links --> allowed browser links --> allowed html editor links --> allowed personal sites --> allowed tutorial sites competing with w3schools --> NOT allowed sites completely irrelevant to webprogramming and this forum --> NOT allowed   Thanks for understanding, and for taking the time to read this. ~W3Schools Modstaff~
bexterinni

Need Two Slideshows — Both with Arrow and Dots

Recommended Posts

bexterinni    0

I have referenced the  W3 slideshow tutorial here and added two slideshows to my web page using Dreamweaver. I understand that the Javascript needs to be edited to accommodate 2 slideshows (divs vs. classes i think?), and I have tried to follow the instructions given here in order to edit it.

Both of my slideshows seem to work independently now, but i can't figure out how to edit the Javascript to make the dots work right. The hover color works (red), but on the second slideshow, the dots do not turn red as the slideshow is advanced.

I know very little about Javascript and I have gone through the Javascript tutorial, but I haven't landed on a solution. I've also searched the forums for an answer, but haven't found one that works for my specific situation.

If anyone could point me toward a solution to have two slideshows on the page that both work pretty much like the one on the W3 tutorial page (with dots and arrows), I'd greatly appreciate your help — ANY guidance about how to fix the code is greatly appreciated.

~bex

Here is my code:

<!DOCTYPE html>
<html>
<head>
<meta name="viewport" content="width=device-width, initial-scale=1">
<style>
* {box-sizing:border-box}
body {font-family: Verdana,sans-serif;margin:0}
.mySlides {display:none}

/* Slideshow container */
.slideshow-container {
  max-width: 1000px;
  position: relative;
  margin: auto;
}

/* Next & previous buttons */
.prev, .next {
  cursor: pointer;
  position: absolute;
  top: 50%;
  width: auto;
  padding: 16px;
  margin-top: -22px;
  color: white;
  font-weight: bold;
  font-size: 18px;
  transition: 0.6s ease;
  border-radius: 0 3px 3px 0;
}

/* Position the "next button" to the right */
.next {
  right: 0;
  border-radius: 3px 0 0 3px;
}

/* On hover, add a black background color with a little bit see-through */
.prev:hover, .next:hover {
  background-color: rgba(0,0,0,0.8);
}

/* Caption text */
.text {
  color: #f2f2f2;
  font-size: 15px;
  padding: 8px 12px;
  position: absolute;
  bottom: 8px;
  width: 100%;
  text-align: center;
}

/* Number text (1/3 etc) */
.numbertext {
  color: #f2f2f2;
  font-size: 12px;
  padding: 8px 12px;
  position: absolute;
  top: 0;
}

/* The dots/bullets/indicators */
.dot {
  cursor:pointer;
  height: 13px;
  width: 13px;
  margin: 0 2px;
  background-color: #bbb;
  border-radius: 50%;
  display: inline-block;
  transition: background-color 0.6s ease;
}

.active, .dot:hover {
  background-color: #f44336;
}

/* Fading animation */
.fade {
  -webkit-animation-name: fade;
  -webkit-animation-duration: 1.5s;
  animation-name: fade;
  animation-duration: 1.5s;
}

@-webkit-keyframes fade {
  from {opacity: .4} 
  to {opacity: 1}
}

@keyframes fade {
  from {opacity: .4} 
  to {opacity: 1}
}

/* On smaller screens, decrease text size */
@media only screen and (max-width: 300px) {
  .prev, .next,.text {font-size: 11px}
}
</style>
</head>
<body>

    <div id="wrapper">
            <div class="slideshow w3-container w3-half">
                <div class="w3-content w3-display-container">
                    <img class="mySlides fade" src="img_nature_wide.jpg" width="100%">
                    <img class="mySlides fade" src="img_fjords_wide.jpg" width="100%">
                    <a class="prev" onclick="plusDivs(-1, 0)">&#10094;</a>
                    <a class="next" onclick="plusDivs(1, 0)">&#10095;</a>
                    <!-- Extra plusDivs parameter refers to first (0) slideshow (start from 0) -->
                </div>
<br>
<div style="text-align:center">
  <span class="dot" onclick="currentDiv(1)"></span> 
  <span class="dot" onclick="currentDiv(2)"></span>  
</div>
            </div>
<hr>
       <div class="slideshow w3-container w3-half">
                <div class="w3-content w3-display-container">
                    <img class="mySlides fade" src="img_nature_wide.jpg" width="100%">
                    <img class="mySlides fade" src="img_fjords_wide.jpg" width="100%">
                    <a class="prev" onclick="plusDivs(-1, 1)">&#10094;</a>
                    <a class="next" onclick="plusDivs(1, 1)">&#10095;</a>
                    <!-- Extra plusDivs parameter refers to second (1) slideshow (start from 0) -->
                </div>
<br>
<div style="text-align:center">
  <span class="dot" onclick="currentDiv(1)"></span> 
  <span class="dot" onclick="currentDiv(2)"></span>  
</div>
      </div>

<script>
    var slideIndex = 1;
    var z = document.getElementsByClassName("slideshow");
    for (i = 0; i < z.length; i++) {
//set custom data attribute to first current image index
    z[i].setAttribute("data-currentslide", 1);
    showDivs(z[i].getAttribute("data-currentslide"), i);
}
    function plusDivs(n, j) {
//get custom data attribute value of current image index to slideshow class index j
    slideIndex = parseInt(z[j].getAttribute("data-currentslide")[0]);
    showDivs(slideIndex += n, j);
}
	function currentDiv(n,j) {
    showSlides(slideIndex += n, j);
}
    function showDivs(n, j) {
    var i;
    var z = document.getElementsByClassName("slideshow")[j];
    var x = z.getElementsByClassName("mySlides");
    var dots = document.getElementsByClassName("dot");
	if (n > x.length) {
    slideIndex = 1
}
    if (n < 1) {
    slideIndex = x.length;
}
//set custom data attribute to current image index
    z.setAttribute("data-currentslide", slideIndex);
    for (i = 0; i < x.length; i++) {
    x[i].style.display = "none";
}
   for (i = 0; i < dots.length; i++) {
   dots[i].className = dots[i].className.replace(" active", "");
}
  x[slideIndex - 1].style.display = "block";
  dots[slideIndex - 1].className += " active";
}
</script>
        
</div>

</body>
</html> 

 

Share this post


Link to post
Share on other sites
justsomeguy    939

You need to add the second parameter when you call currentDiv, like you did with plusDivs.  In order for the function to highlight the correct dot, each of those dot elements needs to specify which slide show it belongs to, so that showDivs can get the correct set of dots.  One way would be to add a class name or data attribute to the dot container elements, or to the dot elements themselves.

  • Thanks 1

Share this post


Link to post
Share on other sites
dsonesuk    701

You had wrongly referenced a JavaScript function, and wrongly named a css selector so very important position: relative was not applied.

<!DOCTYPE html>
<html>
    <head>
        <meta name="viewport" content="width=device-width, initial-scale=1">
        <style>
            * {box-sizing:border-box}
            body {font-family: Verdana,sans-serif;margin:0}
            .mySlides {display:none; width: 100%;}

            /* Slideshow container */
            .slideshow { /*NOT slideshow-container*/
                max-width: 1000px;
                position: relative;
                margin: auto;
            }

            /* Next & previous buttons */
            .prev, .next {
                cursor: pointer;
                position: absolute;
                top: 50%;
                width: auto;
                padding: 16px;
                margin-top: -22px;
                color: white;
                font-weight: bold;
                font-size: 18px;
                transition: 0.6s ease;
                border-radius: 0 3px 3px 0;
            }

            /* Position the "next button" to the right */
            .next {
                right: 0;
                border-radius: 3px 0 0 3px;
            }

            /* On hover, add a black background color with a little bit see-through */
            .prev:hover, .next:hover {
                background-color: rgba(0,0,0,0.8);
            }

            /* Caption text */
            .text {
                color: #f2f2f2;
                font-size: 15px;
                padding: 8px 12px;
                position: absolute;
                bottom: 8px;
                width: 100%;
                text-align: center;
            }

            /* Number text (1/3 etc) */
            .numbertext {
                color: #f2f2f2;
                font-size: 12px;
                padding: 8px 12px;
                position: absolute;
                top: 0;
            }

            /* The dots/bullets/indicators */
            .dot {
                cursor:pointer;
                height: 13px;
                width: 13px;
                margin: 0 2px;
                background-color: #bbb;
                border-radius: 50%;
                display: inline-block;
                transition: background-color 0.6s ease;
            }

            .active, .dot:hover {
                background-color: #f44336;
            }

            /* Fading animation */
            .fade {
                -webkit-animation-name: fade;
                -webkit-animation-duration: 1.5s;
                animation-name: fade;
                animation-duration: 1.5s;
            }

            @-webkit-keyframes fade {
                from {opacity: .4}
                to {opacity: 1}
            }

            @keyframes fade {
                from {opacity: .4}
                to {opacity: 1}
            }

            /* On smaller screens, decrease text size */
            @media only screen and (max-width: 300px) {
                .prev, .next,.text {font-size: 11px}
            }
        </style>
    </head>
    <body>

        <div id="wrapper">
            <div class="slideshow w3-container w3-half">
                <div class="w3-content w3-display-container">
                    <img class="mySlides fade" src="https://www.w3schools.com/howto/img_nature_wide.jpg">
                    <img class="mySlides fade" src="https://www.w3schools.com/howto/img_fjords_wide.jpg">
                    <a class="prev" onclick="plusDivs(-1, 0)">&#10094;</a>
                    <a class="next" onclick="plusDivs(1, 0)">&#10095;</a>
                    <!-- Extra plusDivs parameter refers to first (0) slideshow (start from 0) -->
                </div>
                <br>
                <div style="text-align:center">
                    <span class="dot" onclick="currentDiv(1, 0)"></span>
                    <span class="dot" onclick="currentDiv(2, 0)"></span>
                </div>
            </div>
            <hr>
            <div class="slideshow w3-container w3-half">
                <div class="w3-content w3-display-container">
                    <img class="mySlides fade" src="https://www.w3schools.com/howto/img_nature_wide.jpg">
                    <img class="mySlides fade" src="https://www.w3schools.com/howto/img_fjords_wide.jpg">
                    <a class="prev" onclick="plusDivs(-1, 1)">&#10094;</a>
                    <a class="next" onclick="plusDivs(1, 1)">&#10095;</a>
                    <!-- Extra plusDivs parameter refers to second (1) slideshow (start from 0) -->
                </div>
                <br>
                <div style="text-align:center">
                    <span class="dot" onclick="currentDiv(1, 1)"></span>
                    <span class="dot" onclick="currentDiv(2, 1)"></span>
                </div>
            </div>

            <script>
                var slideIndex = 1;
                var z = document.getElementsByClassName("slideshow");
                for (i = 0; i < z.length; i++) {
                    //set custom data attribute to first current image index
                    z[i].setAttribute("data-currentslide", 1);
                    showDivs(z[i].getAttribute("data-currentslide"), i);
                }
                function plusDivs(n, j) {
                    //get custom data attribute value of current image index to slideshow class index j
                    slideIndex = parseInt(z[j].getAttribute("data-currentslide")[0]);
                    showDivs(slideIndex += n, j);
                }
                function currentDiv(n, j) {
                    showDivs(slideIndex = n, j); /* showDivs Not showSlides*/
                }
                function showDivs(n, j) {
                    var i;
                    var z = document.getElementsByClassName("slideshow")[j];
                    var x = z.getElementsByClassName("mySlides");
                    var dots = z.getElementsByClassName("dot");
                    if (n > x.length) {
                        slideIndex = 1
                    }
                    if (n < 1) {
                        slideIndex = x.length;
                    }
                    //set custom data attribute to current image index
                    z.setAttribute("data-currentslide", slideIndex);
                    for (i = 0; i < x.length; i++) {
                        x[i].style.display = "none";
                    }
                    for (i = 0; i < dots.length; i++) {
                        dots[i].className = dots[i].className.replace(" active", "");
                    }
                    x[slideIndex - 1].style.display = "block";
                    dots[slideIndex - 1].className += " active";
                }
            </script>

        </div>

    </body>
</html>

 

  • Thanks 1

Share this post


Link to post
Share on other sites
bexterinni    0

THANK YOU!! - this is EXACTLY what I needed!!

I am still learning, I know that I have a long way to go. I am VERY appreciative of your time and expertise.

~bex

Share this post


Link to post
Share on other sites
bexterinni    0

Hello again. I have a follow-up question — is there a limit to the number of slides that i can include in the slideshow? The slideshow seems to work if i include only 10 slides, but if i add more than that, and it doesn't work all the way through.

I've added 15 images to my slideshow. If I click the right arrow and try to advance to the 11th slide, instead of going to the 11th slide, it jumps back to slide #2 and starts over - it never gets to the rest of the slides. I can click on the dots for those slides and see them, but not by using the right arrow.

I am wondering if my numbering (below) is incorrect?

~bex

<div style="text-align:center">
                    <span class="dot" onclick="currentDiv(1, 0)"></span>
                    <span class="dot" onclick="currentDiv(2, 0)"></span>
                    <span class="dot" onclick="currentDiv(3, 0)"></span>
                    <span class="dot" onclick="currentDiv(4, 0)"></span>
                    <span class="dot" onclick="currentDiv(5, 0)"></span>
                    <span class="dot" onclick="currentDiv(6, 0)"></span>
                    <span class="dot" onclick="currentDiv(7, 0)"></span>
                    <span class="dot" onclick="currentDiv(8, 0)"></span>
                    <span class="dot" onclick="currentDiv(9, 0)"></span>
                    <span class="dot" onclick="currentDiv(10, 0)"></span>
                    <span class="dot" onclick="currentDiv(11, 0)"></span>
                    <span class="dot" onclick="currentDiv(12, 0)"></span>
                    <span class="dot" onclick="currentDiv(13, 0)"></span>
                    <span class="dot" onclick="currentDiv(14, 0)"></span>
                    <span class="dot" onclick="currentDiv(15, 0)"></span></div>

 

Share this post


Link to post
Share on other sites
dsonesuk    701

My mistake, used for testing forgot to remove.

change

slideIndex = parseInt(z[j].getAttribute("data-currentslide")[0]);

to

slideIndex = parseInt(z[j].getAttribute("data-currentslide")); //lose the [0]

 

  • Thanks 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×