Jump to content
bexterinni

Need Two Slideshows — Both with Arrow and Dots

Recommended Posts

I have referenced the  W3 slideshow tutorial here and added two slideshows to my web page using Dreamweaver. I understand that the Javascript needs to be edited to accommodate 2 slideshows (divs vs. classes i think?), and I have tried to follow the instructions given here in order to edit it.

Both of my slideshows seem to work independently now, but i can't figure out how to edit the Javascript to make the dots work right. The hover color works (red), but on the second slideshow, the dots do not turn red as the slideshow is advanced.

I know very little about Javascript and I have gone through the Javascript tutorial, but I haven't landed on a solution. I've also searched the forums for an answer, but haven't found one that works for my specific situation.

If anyone could point me toward a solution to have two slideshows on the page that both work pretty much like the one on the W3 tutorial page (with dots and arrows), I'd greatly appreciate your help — ANY guidance about how to fix the code is greatly appreciated.

~bex

Here is my code:

<!DOCTYPE html>
<html>
<head>
<meta name="viewport" content="width=device-width, initial-scale=1">
<style>
* {box-sizing:border-box}
body {font-family: Verdana,sans-serif;margin:0}
.mySlides {display:none}

/* Slideshow container */
.slideshow-container {
  max-width: 1000px;
  position: relative;
  margin: auto;
}

/* Next & previous buttons */
.prev, .next {
  cursor: pointer;
  position: absolute;
  top: 50%;
  width: auto;
  padding: 16px;
  margin-top: -22px;
  color: white;
  font-weight: bold;
  font-size: 18px;
  transition: 0.6s ease;
  border-radius: 0 3px 3px 0;
}

/* Position the "next button" to the right */
.next {
  right: 0;
  border-radius: 3px 0 0 3px;
}

/* On hover, add a black background color with a little bit see-through */
.prev:hover, .next:hover {
  background-color: rgba(0,0,0,0.8);
}

/* Caption text */
.text {
  color: #f2f2f2;
  font-size: 15px;
  padding: 8px 12px;
  position: absolute;
  bottom: 8px;
  width: 100%;
  text-align: center;
}

/* Number text (1/3 etc) */
.numbertext {
  color: #f2f2f2;
  font-size: 12px;
  padding: 8px 12px;
  position: absolute;
  top: 0;
}

/* The dots/bullets/indicators */
.dot {
  cursor:pointer;
  height: 13px;
  width: 13px;
  margin: 0 2px;
  background-color: #bbb;
  border-radius: 50%;
  display: inline-block;
  transition: background-color 0.6s ease;
}

.active, .dot:hover {
  background-color: #f44336;
}

/* Fading animation */
.fade {
  -webkit-animation-name: fade;
  -webkit-animation-duration: 1.5s;
  animation-name: fade;
  animation-duration: 1.5s;
}

@-webkit-keyframes fade {
  from {opacity: .4} 
  to {opacity: 1}
}

@keyframes fade {
  from {opacity: .4} 
  to {opacity: 1}
}

/* On smaller screens, decrease text size */
@media only screen and (max-width: 300px) {
  .prev, .next,.text {font-size: 11px}
}
</style>
</head>
<body>

    <div id="wrapper">
            <div class="slideshow w3-container w3-half">
                <div class="w3-content w3-display-container">
                    <img class="mySlides fade" src="img_nature_wide.jpg" width="100%">
                    <img class="mySlides fade" src="img_fjords_wide.jpg" width="100%">
                    <a class="prev" onclick="plusDivs(-1, 0)">&#10094;</a>
                    <a class="next" onclick="plusDivs(1, 0)">&#10095;</a>
                    <!-- Extra plusDivs parameter refers to first (0) slideshow (start from 0) -->
                </div>
<br>
<div style="text-align:center">
  <span class="dot" onclick="currentDiv(1)"></span> 
  <span class="dot" onclick="currentDiv(2)"></span>  
</div>
            </div>
<hr>
       <div class="slideshow w3-container w3-half">
                <div class="w3-content w3-display-container">
                    <img class="mySlides fade" src="img_nature_wide.jpg" width="100%">
                    <img class="mySlides fade" src="img_fjords_wide.jpg" width="100%">
                    <a class="prev" onclick="plusDivs(-1, 1)">&#10094;</a>
                    <a class="next" onclick="plusDivs(1, 1)">&#10095;</a>
                    <!-- Extra plusDivs parameter refers to second (1) slideshow (start from 0) -->
                </div>
<br>
<div style="text-align:center">
  <span class="dot" onclick="currentDiv(1)"></span> 
  <span class="dot" onclick="currentDiv(2)"></span>  
</div>
      </div>

<script>
    var slideIndex = 1;
    var z = document.getElementsByClassName("slideshow");
    for (i = 0; i < z.length; i++) {
//set custom data attribute to first current image index
    z[i].setAttribute("data-currentslide", 1);
    showDivs(z[i].getAttribute("data-currentslide"), i);
}
    function plusDivs(n, j) {
//get custom data attribute value of current image index to slideshow class index j
    slideIndex = parseInt(z[j].getAttribute("data-currentslide")[0]);
    showDivs(slideIndex += n, j);
}
	function currentDiv(n,j) {
    showSlides(slideIndex += n, j);
}
    function showDivs(n, j) {
    var i;
    var z = document.getElementsByClassName("slideshow")[j];
    var x = z.getElementsByClassName("mySlides");
    var dots = document.getElementsByClassName("dot");
	if (n > x.length) {
    slideIndex = 1
}
    if (n < 1) {
    slideIndex = x.length;
}
//set custom data attribute to current image index
    z.setAttribute("data-currentslide", slideIndex);
    for (i = 0; i < x.length; i++) {
    x[i].style.display = "none";
}
   for (i = 0; i < dots.length; i++) {
   dots[i].className = dots[i].className.replace(" active", "");
}
  x[slideIndex - 1].style.display = "block";
  dots[slideIndex - 1].className += " active";
}
</script>
        
</div>

</body>
</html> 

 

Share this post


Link to post
Share on other sites

You need to add the second parameter when you call currentDiv, like you did with plusDivs.  In order for the function to highlight the correct dot, each of those dot elements needs to specify which slide show it belongs to, so that showDivs can get the correct set of dots.  One way would be to add a class name or data attribute to the dot container elements, or to the dot elements themselves.

  • Thanks 1

Share this post


Link to post
Share on other sites

You had wrongly referenced a JavaScript function, and wrongly named a css selector so very important position: relative was not applied.

<!DOCTYPE html>
<html>
    <head>
        <meta name="viewport" content="width=device-width, initial-scale=1">
        <style>
            * {box-sizing:border-box}
            body {font-family: Verdana,sans-serif;margin:0}
            .mySlides {display:none; width: 100%;}

            /* Slideshow container */
            .slideshow { /*NOT slideshow-container*/
                max-width: 1000px;
                position: relative;
                margin: auto;
            }

            /* Next & previous buttons */
            .prev, .next {
                cursor: pointer;
                position: absolute;
                top: 50%;
                width: auto;
                padding: 16px;
                margin-top: -22px;
                color: white;
                font-weight: bold;
                font-size: 18px;
                transition: 0.6s ease;
                border-radius: 0 3px 3px 0;
            }

            /* Position the "next button" to the right */
            .next {
                right: 0;
                border-radius: 3px 0 0 3px;
            }

            /* On hover, add a black background color with a little bit see-through */
            .prev:hover, .next:hover {
                background-color: rgba(0,0,0,0.8);
            }

            /* Caption text */
            .text {
                color: #f2f2f2;
                font-size: 15px;
                padding: 8px 12px;
                position: absolute;
                bottom: 8px;
                width: 100%;
                text-align: center;
            }

            /* Number text (1/3 etc) */
            .numbertext {
                color: #f2f2f2;
                font-size: 12px;
                padding: 8px 12px;
                position: absolute;
                top: 0;
            }

            /* The dots/bullets/indicators */
            .dot {
                cursor:pointer;
                height: 13px;
                width: 13px;
                margin: 0 2px;
                background-color: #bbb;
                border-radius: 50%;
                display: inline-block;
                transition: background-color 0.6s ease;
            }

            .active, .dot:hover {
                background-color: #f44336;
            }

            /* Fading animation */
            .fade {
                -webkit-animation-name: fade;
                -webkit-animation-duration: 1.5s;
                animation-name: fade;
                animation-duration: 1.5s;
            }

            @-webkit-keyframes fade {
                from {opacity: .4}
                to {opacity: 1}
            }

            @keyframes fade {
                from {opacity: .4}
                to {opacity: 1}
            }

            /* On smaller screens, decrease text size */
            @media only screen and (max-width: 300px) {
                .prev, .next,.text {font-size: 11px}
            }
        </style>
    </head>
    <body>

        <div id="wrapper">
            <div class="slideshow w3-container w3-half">
                <div class="w3-content w3-display-container">
                    <img class="mySlides fade" src="https://www.w3schools.com/howto/img_nature_wide.jpg">
                    <img class="mySlides fade" src="https://www.w3schools.com/howto/img_fjords_wide.jpg">
                    <a class="prev" onclick="plusDivs(-1, 0)">&#10094;</a>
                    <a class="next" onclick="plusDivs(1, 0)">&#10095;</a>
                    <!-- Extra plusDivs parameter refers to first (0) slideshow (start from 0) -->
                </div>
                <br>
                <div style="text-align:center">
                    <span class="dot" onclick="currentDiv(1, 0)"></span>
                    <span class="dot" onclick="currentDiv(2, 0)"></span>
                </div>
            </div>
            <hr>
            <div class="slideshow w3-container w3-half">
                <div class="w3-content w3-display-container">
                    <img class="mySlides fade" src="https://www.w3schools.com/howto/img_nature_wide.jpg">
                    <img class="mySlides fade" src="https://www.w3schools.com/howto/img_fjords_wide.jpg">
                    <a class="prev" onclick="plusDivs(-1, 1)">&#10094;</a>
                    <a class="next" onclick="plusDivs(1, 1)">&#10095;</a>
                    <!-- Extra plusDivs parameter refers to second (1) slideshow (start from 0) -->
                </div>
                <br>
                <div style="text-align:center">
                    <span class="dot" onclick="currentDiv(1, 1)"></span>
                    <span class="dot" onclick="currentDiv(2, 1)"></span>
                </div>
            </div>

            <script>
                var slideIndex = 1;
                var z = document.getElementsByClassName("slideshow");
                for (i = 0; i < z.length; i++) {
                    //set custom data attribute to first current image index
                    z[i].setAttribute("data-currentslide", 1);
                    showDivs(z[i].getAttribute("data-currentslide"), i);
                }
                function plusDivs(n, j) {
                    //get custom data attribute value of current image index to slideshow class index j
                    slideIndex = parseInt(z[j].getAttribute("data-currentslide")[0]);
                    showDivs(slideIndex += n, j);
                }
                function currentDiv(n, j) {
                    showDivs(slideIndex = n, j); /* showDivs Not showSlides*/
                }
                function showDivs(n, j) {
                    var i;
                    var z = document.getElementsByClassName("slideshow")[j];
                    var x = z.getElementsByClassName("mySlides");
                    var dots = z.getElementsByClassName("dot");
                    if (n > x.length) {
                        slideIndex = 1
                    }
                    if (n < 1) {
                        slideIndex = x.length;
                    }
                    //set custom data attribute to current image index
                    z.setAttribute("data-currentslide", slideIndex);
                    for (i = 0; i < x.length; i++) {
                        x[i].style.display = "none";
                    }
                    for (i = 0; i < dots.length; i++) {
                        dots[i].className = dots[i].className.replace(" active", "");
                    }
                    x[slideIndex - 1].style.display = "block";
                    dots[slideIndex - 1].className += " active";
                }
            </script>

        </div>

    </body>
</html>

 

  • Like 1
  • Thanks 1

Share this post


Link to post
Share on other sites

Hello again. I have a follow-up question — is there a limit to the number of slides that i can include in the slideshow? The slideshow seems to work if i include only 10 slides, but if i add more than that, and it doesn't work all the way through.

I've added 15 images to my slideshow. If I click the right arrow and try to advance to the 11th slide, instead of going to the 11th slide, it jumps back to slide #2 and starts over - it never gets to the rest of the slides. I can click on the dots for those slides and see them, but not by using the right arrow.

I am wondering if my numbering (below) is incorrect?

~bex

<div style="text-align:center">
                    <span class="dot" onclick="currentDiv(1, 0)"></span>
                    <span class="dot" onclick="currentDiv(2, 0)"></span>
                    <span class="dot" onclick="currentDiv(3, 0)"></span>
                    <span class="dot" onclick="currentDiv(4, 0)"></span>
                    <span class="dot" onclick="currentDiv(5, 0)"></span>
                    <span class="dot" onclick="currentDiv(6, 0)"></span>
                    <span class="dot" onclick="currentDiv(7, 0)"></span>
                    <span class="dot" onclick="currentDiv(8, 0)"></span>
                    <span class="dot" onclick="currentDiv(9, 0)"></span>
                    <span class="dot" onclick="currentDiv(10, 0)"></span>
                    <span class="dot" onclick="currentDiv(11, 0)"></span>
                    <span class="dot" onclick="currentDiv(12, 0)"></span>
                    <span class="dot" onclick="currentDiv(13, 0)"></span>
                    <span class="dot" onclick="currentDiv(14, 0)"></span>
                    <span class="dot" onclick="currentDiv(15, 0)"></span></div>

 

Share this post


Link to post
Share on other sites

My mistake, used for testing forgot to remove.

change

slideIndex = parseInt(z[j].getAttribute("data-currentslide")[0]);

to

slideIndex = parseInt(z[j].getAttribute("data-currentslide")); //lose the [0]

 

  • Thanks 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×