Jump to content
  • Announcements

    • boen_robot

      Guidelines and Netiquette   03/28/2017

      Posting Problems:   Having problems posting your topic? Read through this: To join, you agree to our terms and conditions and fill out and submit a registration form. An activation email will be sent to your email adress, so you'll need to verify your account. After that the account has to be validated by one of the moderators. This will mean that it can take up to a day to be activated. A couple of things to remember to ensure approval: Don't use an email address in one of those $2 four character .com domains eg. xyds.com. These will be deleted and the domain added to the banned list. Don't use an email address that is within a domain with a bad reputation for spam. A Google search is run on every email address and email domain. Don't sign up with an email address that doesn't exist, doesn't work or requires the sender to answer a quiz before their email can get to you. Put your country and or state and city in the signup form. Blank forms will go to the botton of the "to do" list. And make sure that your email address and your country match, saying you're from Alabama and using a .ru email address is not going to get you activated. After a membership is activated the first few posts will be monitored. Posting spam or unapproved topics described in the agreement results in an immediate ban. The email provider and the IP addresses associated with the account will be banned and all posts will be deleted. These strict measures have been deemed necessary to hinder spam. Sorry for any inconvenience this causes, but it's not liable to change. If, after reading this, you still can't post and don't understand why, contact one of the Moderators listed here.   Topic Guidelines   Including the following information can expedite an accurate response from board members: Must be a Specific Problem or Question related to web design and development Include Code in Question (wrap with   for small blocks of code and for longer blocks   ) Include Code Author Include Extra Notes/Modifications/Attempts Include web link to page/file when possible Content Guidelines   You may not post, upload, link to, or email any Content that contains, promotes, gives instruction about, or provides prohibited Content. Prohibited Content includes any Content that breaks any local, state, county, national or international law. Prohibited Content also includes: No direct or indirect advertising or websites, forums, products, services No hijacking of posts (do not post your question in someone elses) Content that infringes upon any rights [ex. MP3s and ROMs] (including, but not limited to, copyrights and trademarks) Abusive, threatening, defamatory, racist, or obscene Viruses or any other harmful computer software False Information or libel Spam, chain letters, or Pyramid schemes Gambling or Illicit drugs Terrorism Hacking or cheating for internet/online games Warez, Roms, CD-Keys, Cracks, Passwords, or Serial Numbers Pornography, nudity, or sexual material of any kind Excessive profanity Invasive of privacy or impersonation of any person/entity Hacking materials or information Posting Tips   There are more BBcodes than there are buttons for on the reply menu. To get the full list, click "BB Code Help" underneath the clickable smilie face menu. Use   for small snippets of code Use   for lengthy snippets of code Use   if your snippet is HTML (optional) Use   if your snippet is SQL (optional) Rules of Conduct   Be nice. There's no need for calling someone stupid if they ask an 'easy' question. Keep your avatars and signatures absolutely child friendly. We have a younger audience on this forum. Keep your language appropriate for the same reason above. Do not PM moderators for help on the forum. Post on the topic, or create a new one.   Spam:   Recently, as you have all without doubt noticed, we have had lots of spam and advertisement on the forum. Therefore, we'd like to alert you as to what to do when you have found any of the aforementioned annoying messages: it. Immediately. Give a clear reason, please, if the advertising is not evident. DO NOT POST! Report, let the post stay as is, and we will get to it, meanwhile if you continue to post as normal in the other threads, it won't be on the top so long. Refrain from PMing the member. This won't help at all, as they are most likely spambots anyway. Thank you.       Images in signatures:   After thinking of users on dial-up, we have decided to enforce the following rules regarding signatures. Please pay heed to them. Respecting these rules is respecting the members on this forum with dial-up. Signature rules: No animated images AT ALL. No matter the amount of animation. Maximum image widthxheight: 300x150 Maximum image (file) size: 15kb Use calm colors. Do not use highly contrasting images in your signature, as this can get really annoying when seeing several posts from one member in the same thread. The same prohibited content goes for images as for posts. Lastly, use common sense. No lengthy signatures please. Save us some scrolling. Thank you.       Links in signatures:   Please understand that w3schools.com only exists because of voluntary work and is barely supported by the advertising littered throughout the tutorials and the forum. So, please, stop advertising other sites. DO not post links that drive traffic away from the w3schools domain - especially to a site that offers similar if not identical information. Please help support the site by keeping individuals on it. Thank you. Here are some guidelines as to what you can put in your signature: w3schools links --> allowed w3.org links --> allowed browser links --> allowed html editor links --> allowed personal sites --> allowed tutorial sites competing with w3schools --> NOT allowed sites completely irrelevant to webprogramming and this forum --> NOT allowed   Thanks for understanding, and for taking the time to read this. ~W3Schools Modstaff~
Weiss

im struggling bad here please help

Recommended Posts

Hi. ive been struggling for 2 hours over this and i just cannot understand whats wrong here.

im trying to create a signup.php where there is a form in the index. with post method, and the inputs are username, password and confirmed password.

in the php file i some functions (like isExist($username) which return true if someone wanna sign up with a username that already exist..)

im embedding the code here:

<?php
//First define some functions..
function isExist ($username){//Return TRUE if name already exist in users table
  $query = "SELECT * FROM users WHERE username = $username";
  $result = mysqli_query($con, $query) or die ('Cannot use SELECT query');
  return (mysqli_num_rows($result) != 0);//Since username can be only 1 per name, any number !=0 means 1 actually..
}

function passChk($password, $conf_pass){//Return TRUE if pass and confirmed pass match
  return ($password == $conf_pass);
}

function newUser ($username, $password){//Add a new user .. duh ;p
  if (!isExist($username)) {
    if (passChk($pass, $conf_pass)){
      $query  = "INSERT INTO 'users' (username, password, id) VALUES ('$username', '$password')";
      mysqli_query($con, $query) or die ("Cannot INSERT into Database");
      echo 'Username Created successfully';
    } else {echo '<script>alert ("Password and confirmed password do not match")</script>';
      header("Location: http://www.sweiss.co.il/sfn/index.html");
    }
  } else { echo '<script>alert ("Username already exist!")</script>';
    header("Location: http://www.sweiss.co.il/sfn/index.html");
  }
  mysqli_close($con);
}
//Code start
require_once('connectvars.php');
$con = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME) or die ('Cannot create connection to Database');
mysqli_set_charset($con, "utf8") or die ('Could not set utf-8');//Will allow us to use hebrew
$username = mysqli_real_escape_string($con, trim($_POST['username']));//Defence vs sql injection
$password = mysqli_real_escape_string($con, trim($_POST['password']));
$conf_pass = mysqli_real_escape_string($con, trim($_POST['conf_pass']));


newUser ($username, $password);

?>

i keep getting the error from the first function isExist.. cannot use SELECT query.

plase any help would be much appriciated

Share this post


Link to post
Share on other sites
function newUser ($username, $password){
  $return = ['success' => false, 'message' => ''];

  if (!isExist($username)) {
    if (passChk($pass, $conf_pass)){
      
      // insert into the database here
      
      $return['message'] = 'Username Created successfully';
      $return['success'] = true;
    } else {
      $return['message'] = "Password and confirmed password do not match";
    }
  } else { 
    $return['message'] = 'Username already exists';
  }
  return $return;
}

 

  • Like 1

Share this post


Link to post
Share on other sites

The forum completely wiped out my reply when I tried to edit my post, because the forum software is awesome. I'll try that again.

  • Like 1

Share this post


Link to post
Share on other sites

The reason why your code isn't working is because $con is not defined in those functions (and $pass and $conf_pass are not defined in newUser either).  You can use global variables inside the function, but it's better to avoid globals and pass in any variables you want the functions to use.  So you should pass $con to the functions.

You should add this to the top of your code:

ini_set('display_errors', 1);
	error_reporting(E_ALL);

You should switch your database code to use prepared statements instead of trying to manually escape everything.  Prepared statements offer better security.  You can use prepared statements with mysqli, but it's better to use PDO.  The PDO code is shorter and easier to understand, and PDO works with databases other than only MySQL.  e.g.:

$stmt = $pdo->prepare("SELECT * FROM users WHERE username = ?");
if ($stmt->execute(array($username))) {
  if ($row = $stmt->fetch()) {
    // it found a user
  }
}

http://php.net/manual/en/book.pdo.php

For the code I posted above, I was saying that each function should only do one thing.  Your newUser function should only validate and add the user if necessary, it should not also output anything or redirect.  Your main code should do that based on what the function returned.  If you want to return multiple values you can use an array like I did above to return a "success" value for whether the user was added, and a message to show them.  So your main code would call that function and then decide what to do.  Those header redirects wouldn't work though, because you sent output to the browser first.

$result = newUser(...);
	if ($result['success']) {
	  // maybe redirect to a thank-you page or something
	}
	else {
	  // show the error in $result['message']
	}

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×