Jump to content
  • Announcements

    • boen_robot

      Guidelines and Netiquette   03/28/2017

      Posting Problems:   Having problems posting your topic? Read through this: To join, you agree to our terms and conditions and fill out and submit a registration form. An activation email will be sent to your email adress, so you'll need to verify your account. After that the account has to be validated by one of the moderators. This will mean that it can take up to a day to be activated. A couple of things to remember to ensure approval: Don't use an email address in one of those $2 four character .com domains eg. xyds.com. These will be deleted and the domain added to the banned list. Don't use an email address that is within a domain with a bad reputation for spam. A Google search is run on every email address and email domain. Don't sign up with an email address that doesn't exist, doesn't work or requires the sender to answer a quiz before their email can get to you. Put your country and or state and city in the signup form. Blank forms will go to the botton of the "to do" list. And make sure that your email address and your country match, saying you're from Alabama and using a .ru email address is not going to get you activated. After a membership is activated the first few posts will be monitored. Posting spam or unapproved topics described in the agreement results in an immediate ban. The email provider and the IP addresses associated with the account will be banned and all posts will be deleted. These strict measures have been deemed necessary to hinder spam. Sorry for any inconvenience this causes, but it's not liable to change. If, after reading this, you still can't post and don't understand why, contact one of the Moderators listed here.   Topic Guidelines   Including the following information can expedite an accurate response from board members: Must be a Specific Problem or Question related to web design and development Include Code in Question (wrap with   for small blocks of code and for longer blocks   ) Include Code Author Include Extra Notes/Modifications/Attempts Include web link to page/file when possible Content Guidelines   You may not post, upload, link to, or email any Content that contains, promotes, gives instruction about, or provides prohibited Content. Prohibited Content includes any Content that breaks any local, state, county, national or international law. Prohibited Content also includes: No direct or indirect advertising or websites, forums, products, services No hijacking of posts (do not post your question in someone elses) Content that infringes upon any rights [ex. MP3s and ROMs] (including, but not limited to, copyrights and trademarks) Abusive, threatening, defamatory, racist, or obscene Viruses or any other harmful computer software False Information or libel Spam, chain letters, or Pyramid schemes Gambling or Illicit drugs Terrorism Hacking or cheating for internet/online games Warez, Roms, CD-Keys, Cracks, Passwords, or Serial Numbers Pornography, nudity, or sexual material of any kind Excessive profanity Invasive of privacy or impersonation of any person/entity Hacking materials or information Posting Tips   There are more BBcodes than there are buttons for on the reply menu. To get the full list, click "BB Code Help" underneath the clickable smilie face menu. Use   for small snippets of code Use   for lengthy snippets of code Use   if your snippet is HTML (optional) Use   if your snippet is SQL (optional) Rules of Conduct   Be nice. There's no need for calling someone stupid if they ask an 'easy' question. Keep your avatars and signatures absolutely child friendly. We have a younger audience on this forum. Keep your language appropriate for the same reason above. Do not PM moderators for help on the forum. Post on the topic, or create a new one.   Spam:   Recently, as you have all without doubt noticed, we have had lots of spam and advertisement on the forum. Therefore, we'd like to alert you as to what to do when you have found any of the aforementioned annoying messages: it. Immediately. Give a clear reason, please, if the advertising is not evident. DO NOT POST! Report, let the post stay as is, and we will get to it, meanwhile if you continue to post as normal in the other threads, it won't be on the top so long. Refrain from PMing the member. This won't help at all, as they are most likely spambots anyway. Thank you.       Images in signatures:   After thinking of users on dial-up, we have decided to enforce the following rules regarding signatures. Please pay heed to them. Respecting these rules is respecting the members on this forum with dial-up. Signature rules: No animated images AT ALL. No matter the amount of animation. Maximum image widthxheight: 300x150 Maximum image (file) size: 15kb Use calm colors. Do not use highly contrasting images in your signature, as this can get really annoying when seeing several posts from one member in the same thread. The same prohibited content goes for images as for posts. Lastly, use common sense. No lengthy signatures please. Save us some scrolling. Thank you.       Links in signatures:   Please understand that w3schools.com only exists because of voluntary work and is barely supported by the advertising littered throughout the tutorials and the forum. So, please, stop advertising other sites. DO not post links that drive traffic away from the w3schools domain - especially to a site that offers similar if not identical information. Please help support the site by keeping individuals on it. Thank you. Here are some guidelines as to what you can put in your signature: w3schools links --> allowed w3.org links --> allowed browser links --> allowed html editor links --> allowed personal sites --> allowed tutorial sites competing with w3schools --> NOT allowed sites completely irrelevant to webprogramming and this forum --> NOT allowed   Thanks for understanding, and for taking the time to read this. ~W3Schools Modstaff~
westman

skipping a loop or two in a while loop

Recommended Posts

Hi all,
I would like to escape a loop if $mainRow's value has already been called.
Here is what I have but it is not working.

while ($stmt->fetch()) {
$mail_main[] = $mainRow;

$main_arr .= ''.$main_arr.', '.$mainRow.'';
$main_arr_array = explode(",", $main_arr);
if (in_array($mainRow, $main_arr_array, TRUE)){
continue;
//break;
}
}

 

Edited by westman

Share this post


Link to post
Share on other sites

If you want to exit the loop you can use break instead of continue.

That code is pretty weird though.  Why do you concatenate everything in a string and then explode to an array, why not just add the new value to the array?  Also, wouldn't that in_array check always be true, because you just added it to the array right before checking?

Share this post


Link to post
Share on other sites

thank you.
I didn't see that.
I have updated my code

$main_arr_array = explode(",", $main_arr);
if (in_array($mainRow, $main_arr_array, TRUE)){
continue;
//break;
}
$main_arr .= ''.$mainRow.', ';

echo $main_arr;

This is the result...
5, 6, 5, 4, 3, 2, 1,
I only want one 5 to show.
How do I skip the loop?

Edited by westman

Share this post


Link to post
Share on other sites

Use temporary empty array $tmparray, and check through each value to check that the value is not in array !in_array() ($tmparray), if not, then add to the $tmparray.

At the end

echo implode(", ",$tmparray);

Share this post


Link to post
Share on other sites

I have updated the code once more...

$main_arr = '';
$main_arr_array = "";
// code
while ($stmt->fetch()) {
$mail_main[] = $mainRow;

$main_arr_array = explode(",", $main_arr);
if (in_array($mainRow, $main_arr_array, TRUE)){
continue;
//break;
}else{
$main_arr .= ''.$mainRow.', ';
//$main_arr .= implode(", ",$mainRow);
//$tmparray = implode(", ",$tmparray);
}

}


I am still not getting the skip.
Could you give a code example please?
 

Share this post


Link to post
Share on other sites

You should not be using strings for this operation, work with arrays and then convert the result to a string (if necessary) when you're done.

I also recommend using a set rather than a list to check for duplicate items. A set is a data structure where the item itself is its own identifier. Finding an item in a set is much faster than searching for it in a list.

$already_used = []; // This is a set
$list = []; // This is a list

// Loop through results
while($row = $stmt->fetch()) {

  // Make sure that the item is not already in the set
  if(!isset($already_used[$row])) {

    // Add the item to the set
    $already_used[$row] = true;

    // Add the item to the list
    list[] = $row;

  }
}

// If necessary, convert the result into a comma-separated string
$output = implode(',', $list);

 

Share this post


Link to post
Share on other sites
        $uniqueValueArray = [];
        while($row = $stmt->fetch()) {

            if (!in_array($row, $uniqueValueArray)) {
                $uniqueValueArray[] = $row;
            }
        }

        echo implode(', ', $uniqueValueArray);

 

Share this post


Link to post
Share on other sites

thank you very much for the examples.
I am not sure I am using them right in my code.
 

while ($stmt->fetch()) {
$mail_main[] = $mainRow;

//$uniqueValueArray = []; this alone shows an error in Dreamweaver
$uniqueValueArray [] = $mainRow;
while($row = $stmt->fetch()) {

if (!in_array($row, $uniqueValueArray)) {
$uniqueValueArray[] = $row;
}
}

} // END while ($stmt->fetch()) {
echo implode(', ', $uniqueValueArray);

What am I doing so wrong?

Edited by westman

Share this post


Link to post
Share on other sites

IF $mainRow represents a single variable value then

$uniqueValueArray = []; // this is now the normal way of declaring a array variable since PHP 5.4
while ($stmt->fetch()) {

if (!in_array($mainRow, $uniqueValueArray)) {
$uniqueValueArray[] = $mainRow;
}

} // END while ($stmt->fetch())

echo implode(', ', $uniqueValueArray);

 

  • Like 1

Share this post


Link to post
Share on other sites

Dsonesuk,
Thank you.
Here is my new code


$uniqueValueArray = [];

while ($stmt->fetch()) {
$mail_main[] = $mainRow;

if (!in_array($mainRow, $uniqueValueArray)) {
$uniqueValueArray[] = $mainRow;
}else{
continue;
}

} // END while ($stmt->fetch()) {
echo implode(', ', $uniqueValueArray);


It seems to work well.
Is there any way I can remove the error Adobe DW is showing me with $uniqueValueArray = []; ?

Share this post


Link to post
Share on other sites

Yeah! simple don't use it! or get a version that don't report it as an error, as I said, its totally valid since php version 5.4 and since where up to php version 7 now! It should accept this as valid.

Share this post


Link to post
Share on other sites

The 'continue' is not required, it does nothing, as all the values will be looped through, and does nothing with values added to arrays.

Share this post


Link to post
Share on other sites

without

else{
continue;
}


my code pulls out duplicates from the database.
my code only works correctly with "continue;" in place.
 

Share this post


Link to post
Share on other sites

Only from this

$mail_main[] = $mainRow;

because its not filtering duplicates, if you want that filtered change all '$uniqueValueArray' to '$mail_main'

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×