Checking If Div Overlaps Browser

[ben03]

Hi there,

 I am trying to check whether a div overlaps the browser height using getBoundingClientRect().height and comparing it to window.innerHeight:

css

#container {
min-height: 100vh
}

JS

document.addEventListener("DOMContentLoaded", function() {
    let landingScreen = document.getElementById('container')    
    let getHeight = window.innerHeight
    let landingHeight = landingScreen.getBoundingClientRect().height
    if (landingHeight <= getHeight) {
        do this
    } else {
        do that 
    }
}

However this doesn't seem to always return accurate results. sometimes it considers the div to be the height of the window, even when content is clearly overlapping. Is there a more robust way of achieving this?

Thanks

[niche]

Best to use your developer tools.  That way you can actually see what you're dealing with.

[ben03]

Printing to the console shows the div and browser height as the same, despite some of the content of the div spilling out of view. It is almost like it is treating min-height as max-height. Are there possibly some compatibility issues with using 100vh and javascript getBoundingClientRect()?

[Ingolme]

I suspect some margins may be escaping the container. The quick solution to that would be to add overflow: hidden to #container.

Another possibility is that images are changing the height of the container. Since DOMContentLoaded usually fires before images have loaded, the images are not adding to the height of the container at the time that the event fired.

[ben03]

Thanks Ingolme, images could well be the problem here. What would be better to use than DOMContentLoaded in this instance?

[Ingolme]

Just the "load" event.