jarrett000 Posted April 8, 2009 Share Posted April 8, 2009 This is just a prottotype site until I can get good enough at it, by default I did what w3schools does (not nearly as well) and like I said this site is just my foundation.I've been working on it for some time now (thus the lot of question I ask here) but I don't think it's good enough yet. I would like some criticism (or praise) from both the code and looks point of view so I can adress both correctly.This is it. Link to comment Share on other sites More sharing options...
Yvil Posted April 8, 2009 Share Posted April 8, 2009 Hey Jarrett,The first thing that caught my eye was the fact that the navigation buttons and the banner size with the window.I don't think this is good, since it makes the images look bad quality. You might wanna change that.Also, because you made it a full-screen website, it looks like there's not enough content. I don't like full-screen websites, but it's up to you.Last thing I'd change a bit are the colours. You took a good matched set of colours, but it's a bit plain to only see 2 colours.You can fix this by using more pictures or just change the CSS so it uses more colours.Altogether I think it's a good website, keep improving and it'll be perfect!~ Yvil Link to comment Share on other sites More sharing options...
chibineku Posted April 8, 2009 Share Posted April 8, 2009 Hiya. The site does a weird thing when I tried to open it in IE: it kept going to the Mozilla Firefox site. It opened in Firefox fine, though. Strange.I agree about the stretching of images, and that your logo and toolbar would look a lot sharper if they were smaller. The other thing is that some of the HTML you are teaching is a little sloppy, for example the lack of closing tags on any of your tables. That's not good form and, as I understand it, won't work well on the next generation of browsers. Link to comment Share on other sites More sharing options...
virgil Posted April 8, 2009 Share Posted April 8, 2009 hi,your web site forwarded me to a firefox page using iehttp://www.mozilla.com/en-US/firefox/firefox.htmlthe site looks fine, i like the colors.you just need a bit of padding or margin for your main content and of course more content. Link to comment Share on other sites More sharing options...
Shade Posted April 8, 2009 Share Posted April 8, 2009 looks well.but I had a hard time reading blue text on a black background. Link to comment Share on other sites More sharing options...
jarrett000 Posted April 8, 2009 Author Share Posted April 8, 2009 Yes, I gave up trying to fix the problem with IE so I did made it redirect to the firefox dl page. Link to comment Share on other sites More sharing options...
Synook Posted April 9, 2009 Share Posted April 9, 2009 Yes, I gave up trying to fix the problem with IE so I did made it redirect to the firefox dl page. but what about clients in enterprise environments?And why do I have to enter my name?Also, the nav bar is messed up on all the other pages (Chrome on WinXP). Link to comment Share on other sites More sharing options...
jarrett000 Posted April 13, 2009 Author Share Posted April 13, 2009 You don't HAVE to enter you're name, the links to all the pages are there thats so I can adress you personally as opposed to "welcome user" I can say "welcome synook", its optional unless you want the information page. I know the nav bar is messed up but I don't know why, I deleted the css for the bar and then pasted it all back on the index and that fixed but I have no idea why. If you are able to tell me that would be nice I've read over it several times. As for people in enterprise enviroments, frankly, I don't care whatsoever I like firefox so if you're using IE deal with it and dl FF. Link to comment Share on other sites More sharing options...
pizzaguy Posted April 13, 2009 Share Posted April 13, 2009 A bit of a problem that could cause some headaches... because of the way people enter their name, your website is vulnerable to XSS , in which anyone could put arbitrary code into your page to manipulate it (on the client side, not necessarily change the server) http://www.jarrettcode.com/?enterN=%3Cmarq...;%3C/marquee%3E as an example... Link to comment Share on other sites More sharing options...
lucas22 Posted April 14, 2009 Share Posted April 14, 2009 The main things that got the red flag ...1. Buttons are way too large (smaller nav buttons the better)2. Blue text is hard on eyes to read (maybe use white or cream colors for text on top of the dark background.3. Content is lacking. 4. Header is too large (H1)I think you have a nice design going there though. Just keep working on it, that's the only way to learn. Link to comment Share on other sites More sharing options...
alexnofue Posted April 16, 2009 Share Posted April 16, 2009 Hi, i just keep noticing the js function that the page doesn't find. Link to comment Share on other sites More sharing options...
jeffman Posted April 16, 2009 Share Posted April 16, 2009 I'm on Firefox 3 on my Mac, and I got bounced to the Firefox page. I suppose your browser sniffing is incomplete. Link to comment Share on other sites More sharing options...
jarrett000 Posted April 17, 2009 Author Share Posted April 17, 2009 I'm on Firefox 3 on my Mac, and I got bounced to the Firefox page. I suppose your browser sniffing is incomplete.I'm using <!--[if IE]><script type="text/javascript">location.href = "http://www.mozilla.com/en-US/firefox/firefox.html";</script><![endif]--> So I wouldent know why that would happen.----------------------------------------------------------------------------------------- The main things that got the red flag ...1. Buttons are way too large (smaller nav buttons the better)2. Blue text is hard on eyes to read (maybe use white or cream colors for text on top of the dark background.3. Content is lacking.4. Header is too large (H1)I think you have a nice design going there though. Just keep working on it, that's the only way to learn.Thank you for the input, I agree with you mostly, and I'll probably change those things here soon.--------------------------------------------------------------------------------------------A bit of a problem that could cause some headaches...because of the way people enter their name, your website is vulnerable to XSS , in which anyone could put arbitrary code into your page to manipulate it (on the client side, not necessarily change the server)http://www.jarrettcode.com/?enterN=%3Cmarq...;%3C/marquee%3E as an example...I honestly had no idea you could do that, I messed around with it and saw you could enter anything you want pretty much. I think I'll prevent that by returning the form false if any sort of greater or less than symbol is included in the box. Link to comment Share on other sites More sharing options...
Welcome Posted April 23, 2009 Share Posted April 23, 2009 Maybe you should try a whole new design. Also, I can use HTML in the 'enter name' dialog. I didn't do anything bad I just made my name a paragraph. Link to comment Share on other sites More sharing options...
jesh Posted April 23, 2009 Share Posted April 23, 2009 Yeah, you'll probably want to prevent that at some point:http://www.jarrettcode.com/?enterN=%3Cscri...);%3C/script%3E Link to comment Share on other sites More sharing options...
makeitspiffeh Posted June 8, 2009 Share Posted June 8, 2009 "We are currently redisigning our website to fix a few problems as well as improve some of our lessons. We should be back up in less than a month. "You dun spelled design wrong. </suggestion> Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.