File Adds Html?

[kirbyweb]

I have a page where you can download files from your db, but it includes the html on the page to the file does anyone know why? here is the code:

<table><tr><td><form method="POST">Full Name:</td><td><input type="text" name="name" /><br /></td></tr><tr><td>File Name:</td><td><input type="text" name="file_name" /><br /></td></tr><tr><td><input type="submit" name="submit" value="submit" /></form></td></tr></table><?php$name = $_POST['name'];$file_name = $_POST['file_name'];$submit = $_POST['submit'];if ($submit){$connect  $sql = mysql_query("SELECT file_itself, file_type, file_name, file_size FROM `form_files_info` WHERE full_name = '$name' && file_name = '$file_name'");  $count = mysql_num_rows($sql);  if ($count == 0)  {   die('No Name or File Name named that.');  }else  $data = mysql_result($sql, 0, "file_itself");  $name = mysql_result($sql, 0, "file_name");  $size = mysql_result($sql, 0, "file_size");  $type = mysql_result($sql, 0, "file_type");	  header("Content-type: $type");  header("Content-length: $size");  header("Content-Disposition: attachment; filename=$name");  header("Content-Description: PHP Generated Data");  echo $data;}?>

Please help thanks.

[justsomeguy]

Because you're trying to send a bunch of headers and binary data in the middle of an HTML page. Binary file data doesn't include a bunch of HTML tags around it. If you're sending HTML then send HTML, if you're sending a file then send a file. You can't do both at the same time.

[kirbyweb]

I am new to this file part, can you explain which areas?

[justsomeguy]

The part which outputs the file data needs to be its own file, you can't start outputting a binary stream in the middle of an HTML document. You need a link or something else to run your download page, and the only thing it does is look up the file in the database, send the headers, and send the file data.

[kirbyweb]

So you are saying I need a new page for this?

[justsomeguy]

Yes, you need one page where the only output of the script is the file data with appropriate headers. You would link to that script to let someone download a file.

[kirbyweb]

Now I have one more question if I use die, how would I make it appear on the same page, not make it just plain white with the words.

[justsomeguy]

You wouldn't be able to put it on the same page, but you can format the page if you detect the error instead of just printing the text and exiting. You could also check that the ID exists in the database prior to showing the link.

[kirbyweb]

Whats with the printing and exiting is that a solution?

[justsomeguy]

That's what you're doing now, that's what a die or exit statement does. It just prints some text and exits.

[kirbyweb]

So how can I make the script stop but the text appear on the same page?

[justsomeguy]

You can't make text appear on the page where the link is, that's what I said. You can either show just the error, or set up a formatted HTML page and put the error on it, or check for the error before you even show the link in the first place.

[kirbyweb]

No there is no link I am still using the form, I just did action in the form and moved the php code to where ever the action is.So no that we confirmed its not a link, how can I make the text on the die appear on the same page?

[justsomeguy]

This is the third time, so hopefully it sinks in: you can't have one page update another arbitrary page in real time. You just can't. It doesn't matter what the situation is, that's not how HTTP works. The only thing you can do is have Javascript code that will take the error message and call a function on the parent page to send it the error, and the parent page can do whatever it wants with the message. Using window.opener will refer to the page which opened the current page, if you have a function defined on that page called do_error then you can call it from the popup using window.opener.do_error, and you can send your error message to have it update the page.

[kirbyweb]

This is the third time, so hopefully it sinks in: you can't have one page update another arbitrary page in real time. You just can't. It doesn't matter what the situation is, that's not how HTTP works. The only thing you can do is have Javascript code that will take the error message and call a function on the parent page to send it the error, and the parent page can do whatever it wants with the message. Using window.opener will refer to the page which opened the current page, if you have a function defined on that page called do_error then you can call it from the popup using window.opener.do_error, and you can send your error message to have it update the page.

I already did it in php, you just put the html on top of the php code, so you can.

[justsomeguy]

I think we're talking about 2 different things. From my understanding you have a page pop up to download the file, and if there was an error instead of showing the error on that popup you wanted to show it on the parent page. If that's not your situation then I misunderstood.