Jump to content

How Would You Rate My Document Contruction?

RobberBaron

By RobberBaron
in Critiques

Recommended Posts

RobberBaron Newbie

RobberBaron

Posted
Posted

This is the output of the index page for my website. I can only give you the source because I don't want to upload all the files of my website until I'm happy with all of it. Here we go: 

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">  <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" onmousemove="$('ten').fadeIn('slow');" dir="ltr" lang="en">  	<head>  	<!-- head -->  		<!-- page info -->  		<title>RobberBaron Online</title>  		<!-- /page info -->  		<!-- metas -->  		<meta name="keywords" content="robberbaron, online, projects, pudding, and, tallulah, adventures, gtm, get, the, message, forum, etc" /> 		<meta name="description" content="RobberBaron Online - Home; The one place for PATS, GTM, STP, CHIPS, WebLUA and some other funny acronyms you can't live without!" /> 		<meta name="author" content="RobberBaron" /> 		<meta name="generator" content="%20AUTO_NET//" /> 		<meta http-equiv="charset" lang="en" /> 		<meta name="google-site-verification" content="jXdKlrHonIRnNUHhpGaYvx2JMmYdiokyDorezlwD6o8" id="googleHash" /> 		<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />  		<!-- /metas -->  		<!-- links -->  		<link rel="stylesheet" type="text/css" href="/styles/global/global.css" /> 		<link rel="icon" type="image/x-icon" href="/favicon.ico" /> 		<link rel="index" type="text/html" href="/a-z/" />  		<!-- /links -->  		<!-- scripts -->  		<script type="text/javascript" src="/includes/scripts/jquery.js"></script> 		<script type="text/javascript" src="/includes/scripts/menus.js"></script> 		<script type="text/javascript" src="/includes/scripts/system.js"></script> 		<script type="text/javascript" src="/includes/scripts/forms.js" id="/forms"></script> 		<script type="text/javascript" src="/includes/scripts/main.js" id="/main"></script> 		<script type="text/javascript" src="/includes/scripts/jsasp.js" id="/jaasp"></script> 		<script type="text/javascript" src="/includes/scripts/jsasp.asp" id="/aspr"></script> 		<script type="text/javascript" src="/includes/scripts/timer.asp" id="/timer"></script> 		<script type="text/javascript" src="/includes/scripts/events.js" id="/events"></script> 		<script type="text/javascript" src="/includes/scripts/getFileContents.js" id="/FileRequest"></script> 		<script type="text/javascript" src="/includes/scripts/checkUsers.js" id="/CheckUsers"></script> 		<script type="text/javascript" src="/includes/scripts/onLoad.js" id="/onLoad"></script>  		<!-- /scripts -->  	<!-- /head -->  	</head>  	<body onload="$('ten').hide(); onLoad();" oncontextmenu="disableContextMenus();">  		<form name="rbAUTO_NET" id="rbAUTO_NET" action="/document.stp?g=get&hash=false#fh389tu843t439th38u3r8943uffhfhue9wiirhjtyyt83hggh5838th3ijwjd8495738t45gjf393fj3" method="get"> 			<input type="hidden" name="__SESSION_EVENT" id="__SESSION_EVENT" value="null" /> 			<input type="hidden" name="__SESSION_RUN" id="__SESSION_RUN" value="last:0;" /> 			<input type="hidden" name="__SESSION_LAST" id="__SESSION_LAST" value="h.hnull" /> 			<input type="hidden" name="__SESSION_ID" id="__SESSION_ID" value="" />  			<a name="top" id="PAGE_BEGIN" name="PAGE_BEGIN" href="#top" class="BEGIN_"></a>  			<h3>RobberBaron Projects Online</h3> 			<ten> 				<table width="100%"> 					<tr bgcolor="#FF8080"> 						<td onmouseover="showMenu('map');" onmouseout="hideMenu('map');"> 							<a href="/index.php">Home</a> 							<br /> 							<table class="menu" id="map" width="120"> 								<tr> 									<td class="menu"> 										<a href="/projects/">Projects</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="/stories/">Stories</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="/videos/">Videos</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="/downloads.php">Downloads</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="/sitemap.php#home">More...</a> 									</td> 								</tr> 							</table> 						</td> 						<td onmouseover="showMenu('forum');" onmouseout="hideMenu('forum');"> 							<a href="/forum/">Forum</a> 							<br /> 							<table class="menu" id="forum" width="120"> 								<tr> 									<td class="menu"> 										<a href="/forum/">Home</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="/forum/portal.php" title="RobberBaron Projects Forum - Portal">Portal</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="/forum/login.php?do=login" title="RobberBaron Projects Forum - Login">Login</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="/forum/register.php" title="RobberBaron Projects Forum - Register">Register</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="/sitemap.php#forum" title="RobberBaron Online Sitemap - Forum Map">More...</a> 									</td> 								</tr> 							</table> 						</td> 						<td onmouseover="showMenu('links');" onmouseout="hideMenu('links');"> 							<a href="/sitemap.php#links" title="RobberBaron Online Sitemap - Links">Links</a> 							<br /> 							<table class="menu" id="links" width="120"> 								<tr> 									<td class="menu"> 										<a href="/forum/" title="RobberBaron Projects Forum">Forum</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="http://www.justacrossthepond.forumotion.com/" title="Just Across The Pond Forum">Just Across The Pond</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="http://www.wishbone.forumotion.com/" title="Wishbone Forum">Wishbone</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="http://www.evan.evinext.com/forum/" title="Evina Forums">Evina Forums</a> 									</td> 								</tr> 								<tr> 									<td class="menu"> 										<a href="/sitemap.php#links" title="RobberBaron Online Sitemap More Links">More...</a> 									</td> 								</tr> 							</table> 						</td> 					</tr> 				</table> 			</ten> 		<br /><ten>	<span style="width:150;">		Welcome to RobberBaron Projects Online! To get started, click on one of the links above! Suggestions:		<menu>			<li><a href="/forum/" title="Visit The Forum">Visit The Forum</a> to post messages and discuss projects.</li>			<li><a href="/videos/" title="Go To The Video Player">Visit RobberBaron Video Player</a> to watch the latest media.</li>			<li><a href="/projects/" title="Go To The Projects Pages">Visit The Projects Pages</a> to view and download the latest projects.</li>		</menu>		<img src="/images/help.png" title="I Need Help!" alt="I Need Help!" align="left" />		<h3>			<u>			I need help!			</u>			<menu>			Are you stuck? Why not visit our <a href="/sitemap.php" title="Site Map">sitemap</a> to find the page you want. Alternatively, you could <a href="/search/" title="Search The Site">search</a> for pages on the server.			</menu>		</h3>			</span></ten>			<span id="connections" name="connections" class="CODE_">				<code>					<script type="text/javascript">					var __e=function()						{							session.send(session.URL);						}					session.page.rbAUTO_NET.onsubmit.connect(__e);					</script>				</code>			</span>			<div id="timeDiv" name="timeDiv" onload="this.Text=this.innerHTML;">				<center id="innerCenter" name="innerCenter" onload="this.Text=this.innerHTML; this.Load=this.onload; this.Load.connect(WhileTrueDo(this.Text=Response.Write(Now())));">					<script type="text/javascript">					Response.Write(Now());					</script>				</center>			</div>			</form>	</body></html>

'<ten>' is a custom tag that jQuery uses to hide the inner content until the user moves the mouse.

Link to comment
Share on other sites
Synook w3schools Guru

Synook

Posted
Posted
So the HTML Construction is alright then?
Well:
  • don't use tables for layout
  • try to consolidate your scripts and separate them out from your HTML
  • you can't use custom tags like <ten> or <menu> unless you create a custom DTD
  • try to avoid the use of presentational markup like the bgcolor attribute or the <u> tag
  • you can use child selectors in your CSS to avoid having to specify the class on every one of a series of elements
  • a keywords meta is sort-of useless
  • you seem to have gotten confused between ASP and JS in some places
  • that's a lot of JavaScript, have you checked how long it takes to load?

Link to comment
Share on other sites
RobberBaron Newbie

RobberBaron

Posted
  • Author
Posted
Well:
  • don't use tables for layout
  • try to consolidate your scripts and separate them out from your HTML
  • you can't use custom tags like <ten> or <menu> unless you create a custom DTD
  • try to avoid the use of presentational markup like the bgcolor attribute or the <u> tag
  • you can use child selectors in your CSS to avoid having to specify the class on every one of a series of elements
  • a keywords meta is sort-of useless
  • you seem to have gotten confused between ASP and JS in some places
  • that's a lot of JavaScript, have you checked how long it takes to load?

Here we go!
  • What do you recommend for it instead?
  • Okay, will do
  • Well, the <ten> tag works for fading in text onmousemove anyway, and <menu> actually is a HTML tag used for creating unordered lists (aka bullet lists much like this one)
  • Makes sense, I'll just do it with CSS instead
  • Okay, will do
  • Why? Might as well keep it anyway, it's not harming anyone
  • I made a custom script called JS::ASP.js that uses ASP like objects in Javascript.
  • I will use Google's Closure Compiler service to squish up all the codes to make the file types smaller. Should I put it all in one file too?

I like answering things in the order people present them :)

Link to comment
Share on other sites
thescientist w3schools Guru

thescientist

Posted
Posted

you can actually use the HTML tag <ul> for unordered lists. I've never heard of menu before. So use lists for navigation instead of tables, or "menu".

Link to comment
Share on other sites
Synook w3schools Guru

Synook

Posted
Posted
  • CSS and semantically correct elements
  • -
  • well, that doesn't make it valid :)! However, you are right, <menu> is a valid element - it's deprecated though so you may want to use <ul> instead.
    <!-- single column list (DEPRECATED) --> <!ELEMENT menu (li)+>

  • -
  • -
  • as far as anyone can tell, search engines don't use it anymore
  • that's ... interesting, but how much does it slow your page down by?
  • yes, the fewer files the better, because browsers only make a couple of requests at once. But do you need all of them?

Link to comment
Share on other sites
  • 3 months later...
RobberBaron Newbie

RobberBaron

Posted
  • Author
Posted
  • CSS and semantically correct elements
  • -
  • well, that doesn't make it valid :)! However, you are right, <menu> is a valid element - it's deprecated though so you may want to use <ul> instead.
    <!-- single column list (DEPRECATED) --> <!ELEMENT menu (li)+>

  • -
  • -
  • as far as anyone can tell, search engines don't use it anymore
  • that's ... interesting, but how much does it slow your page down by?
  • yes, the fewer files the better, because browsers only make a couple of requests at once. But do you need all of them?

Well, even though <ten> is made up, it still works, because it matches the string selectors that jQuery uses to search by.Also, lots of the files were kinda useless....Anyway thanks for the tips!
Link to comment
Share on other sites
boen_robot w3schools Guru

boen_robot

Posted
Posted

I'd add that you avoid relying on your JavaScript. JavaScript can be disabled by users, unsupported by some (mobile) browsers and is sometimes stripped by corporate and other proxies.So... think of what happens with your <ten> element without any JavaScript.Also, there is a difference between "works", "it works properly" and "works efficiently". I don't know about efficiency, but your way is surely not proper. The reason is not because it isn't working, it's because it may stop working in certain circumstances that may occur in the future (e.g. a newer version of (X)HTML defines <ten/>, and once you switch the DTD, it starts working in ways you've never expected).

Link to comment
Share on other sites
23.12.2012 Member

23.12.2012

Posted
Posted

I think this line is wrong

<meta http-equiv="charset" lang="en" />

I'd get rid of it and the other one

<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

and write, above the DTD

<?xml version="1.0" encoding="utf-8" ?>

I think /jaasp is a typo in here

<script type="text/javascript" src="/includes/scripts/jsasp.js" id="/jaasp"></script>

And all of the above.

Link to comment
Share on other sites
Guest FirefoxRocks

Guest FirefoxRocks

Posted
Posted
and write, above the DTD
<?xml version="1.0" encoding="utf-8" ?>

Actually I do not recommend using the XML processing instruction since this really isn't XML and it will throw IE6 into quirks mode I believe, even though we should be moving away support for IE6, but still, it's not necessary if it isn't application/xml, text/xml or application/xhtml+xml.
Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

Go to topic listing
×
×
  • Create New...