better if statement?

[student101]

Is there a better way to write this if statement?Option1:

if (isset($_GET['item']) || isset($_POST['item'])){   $path = 'uploads/file/'.$filename;}else{    $path = 'uploads/'.$filename;}

Option2:

if ('item' != $_GET['news'] || 'item' !=  $_GET['events'] || 'item' != $_GET['download']){    $path = 'uploads/file/'.$filename;}else{    $path = 'uploads/'.$filename;}

[boen_robot]

What exactly is it that you're trying to do? There isn't a more appropriate way - boh things work, both are appropriate, but they both work differently, so they are appropriate in different contexts.

[justsomeguy]

Since you're setting the same variable in both the if and else blocks you can write the first one like this, just to make it shorter:$path = isset($_GET['item']) || isset($_POST['item']) ? 'uploads/file/'.$filename : 'uploads/'.$filename;

[student101]

they both work differently, so they are appropriate in different contexts.

Not sure what you mean, they both check if item contains anything?

[student101]

$path = isset($_GET['item']) || isset($_POST['item']) ? 'uploads/file/'.$filename : 'uploads/'.$filename;

Good point! Didn't think of the short way.

[boen_robot]

Not sure what you mean, they both check if item contains anything?

No they don't.

isset($_GET['item']) || isset($_POST['item'])

checks if there is an "item" variable in the query string or in the request body.This will be true for a URL like (for example):index.php?itemorindex.php?item=somethingand false forindex.php?news=itemorindex.php?events=notItem

'item' != $_GET['news'] || 'item' !=  $_GET['events'] || 'item' != $_GET['download']

checks if there is a variable "news" or "events" or "download" in the query string that has a value different than the value "item".This will be true for a URL like:index.php?events=notItemorindex.php?news=notItemand false forindex.php?news=item&events=item&download=item

[student101]

Yes that's more technical than what I was looking for, more interested in finding if item contained something.All the same, thanks for your input too.

[boen_robot]

You can do that with

isset($_GET['item']) && !empty($_GET['item'])

This checks if a variable called "item" exists and is not empty. It will be true toindex.php?item=1orindex.php?item=somethingand will be false onindex.php?itemorindex.php?notItemYou could write this condition in either an if statement or in the short form (a.k.a. "ternary operator").

[student101]

You could write this condition in either an if statement or in the short form (a.k.a. "ternary operator").

Now I need to learn, "ternary operator" ?

[boen_robot]

Now I need to learn, "ternary operator" ?

That's what justsomeguy showed you above.

$path = isset($_GET['item']) || isset($_POST['item']) ? 'uploads/file/'.$filename : 'uploads/'.$filename;

The form

condition ? if_true : if_false

is called "ternary operator". See its description in the PHP manual.

[student101]

Got it; "?:" (or ternary) operator

I need to play less games and read more...

I also need to start a new thread with my next question, need to code some test pages first.

[ShadowMage]

isset($_GET['item']) && !empty($_GET['item'])

Doesn't the empty() function test if it's set? So it would be redundant to use isset(), because that would be redundant.

[justsomeguy]

Yes, if you're using empty it's not necessary to use isset.

[boen_robot]

Yes, if you're using empty it's not necessary to use isset.

Maybe it's a habbit from an old version or something... I recall I once used empty on a non existent variable, and got a notice for an undefined variable. It could've been removed in recent versions though... it's been a long time since I last tried the same thing.