Jump to content

callumacrae

Members
  • Posts

    89
  • Joined

  • Last visited

Posts posted by callumacrae

  1. All code
    var cp=0;var duration=800;$(function(){	$('#webdesignerAnime p').css({'visibility': 'hidden'});		$fadethis = (function ()		{		if(cp < $('#webdesignerAnime p').size())			{			$('#webdesignerAnime p').eq(cp).css({'visibility': 'visible' , 'display': 'none'}).fadeIn( duration , function(){			$fadethis();			});		cp++;		}				});		$fadethis();					});

    There are a few problems with this code:
    • The $fadethis variable is undeclared.
    • Your lack of correct spacing makes the code very tricky to read. I initially thought that the $fadethis function was being called immediately inside the $fadethis function, which it isn't.
    • Why have you begun your function name with a dollar sign? This isn't PHP. Sure, do it yourself in your own code, but don't confuse beginners by trying to get them to do it
    • Why are you passing a function which calls $fadethis as a callback? Why not just pass $fadethis?
    • Your line with logic in seems needlessly complicated, and also wrong. How are you hiding the old elements? I suspect you meant to .hide() the elements (which is easier than calling .css() manually), then call .eq(), and then fade the specific element in.
    • Assuming the logic you implemented it correct, everything on the page will jump up a couple hundred pixels wfor a fraction of a second when slides change.
    • There is no way to restart the powerpoint.
    • User cannot manually advance the powerpoint, which would be nice.
    • Why are you hiding the elements using .css()? This is what .hide() was designed for, and it is better at it.

  2. Or if you want to do with double quotes
    $left .= "<div class=\"quotepost\"><div class=\"textdiv\"><q class=\"quotetext\">" . $row['quote'] . "</q></div><p class=\"quoteauthor\">-" . $row['author'] . "</p></div><br/>";

    You shouldn't use double quotes for a string like that, that's ugly.Mind you, you shouldn't really have HTML in a string either.EDIT: yey ipb sucks
  3. How can it be invasive, one pop-up, light-box is classed as a pop-up, you are restricted to the LB pop-up until you are finished with it and then close it, and it is used everywhere, and if you are on a trusted site, you would NOT associate spam with that site so you would enable it, its the new sites you have not visited before you should be wary of, even this site uses a pop-up for login screen, but it has fallback to login page, as for going from parent page to pop-up, usullay the pop would not usually contain info from which you would want to keep returning, unless you have memory of goldfish, and can't remember what you just seen. IF its important info, you usually get the option to print it!
    I get the impression that you don't know what invasive means and that you'd also happily use alert and prompt, light boxes are not popup windows, I'm not sure where you got that from, light boxes are also pretty invasive though, you shouldn't assume that your users will trust you, as a lot of your users won't and you want the website to work for them too, I don't have the memory of a goldfish but I still couldn't remember the beginning of your post when I got to the end of the post, please use sentences and try to not ramble.
  4. Not if you do it such a way that it remains at front until closed, you can also do it to restrict the number of windows at given time. pop-blocker usually come with option to allow pop-up on this site option, before blocking completely, depends how you set it up.
    That sounds crazy invasive. What happens if I want to go to a different tab on the original window and then go back to the popup? Either way, it'll be ugly.I believe that Chrome blocks all popups by default, and doesn't notify the user. Even so, if something comes up saying "popup blocked", most users now just associate popups with spam and so don't tell it to open the popup.
  5. You should never rely on popup windows. They are invasive, often confusing for the user (if their browser is full screen and the popup goes behind it, they have to mess about with windows to get it back), and if they're not blocked by a popup blocker - which a lot of people have enabled - they will often be ignored just because they're popups.

  6. First offYou have written:
    border:2px solid blue;

    It should be:

    border:2px blue solid;

    WRONG! If you want to help, try to get your facts straight otherwise your making a fool of your self arsehole. And i'm sorry but you seem to have the impression that i really care what you think, i can tell you that i don't!.

    Ah, my bad. I didn't test whether the first code sample actually worked, so I assumed that it must be the other way round and tested that. They both work for me. OP: What specifically isn't working, and in what browser? It's working for me.
  7. How do I add a border to a link? (I've tried many times!)Just: #'link' {border:}
    You have written:
    border:2px solid blue;

    It should be:

    border:2px blue solid;

    What??? stop talking double dutch. numpty.
    Either help, or don't. You're making a fool of yourself.
  8. you need css similar to this, submenu UL set to position: absolute; and add a fixed width. With the LI you should remove padding and give it 100% width to stretch full width of UL, causing it to stake, make anchor elements block, and also 100% width.
    #mainNav li {	float: left;	/*padding-left: 21px;*/} #mainNav a {	-moz-font-feature-settings: normal;	-moz-font-language-override: normal;	-moz-text-blink: none;	-moz-text-decoration-color: -moz-use-text-color;	-moz-text-decoration-line: none;	-moz-text-decoration-style: solid;	-x-system-font: none;	color: #FFFFFF;	display: block; /*added by dsonesuk*/	font-family: "ITCAvantGarde",Helvetica,Arial,sans-serif;	font-size: 14px;	font-size-adjust: none;	font-stretch: normal;	font-style: normal;	font-variant: normal;	font-weight: normal;	line-height: normal;	padding-bottom: 0;	padding-left: 20px;  /* padding-left: 10px; amended by dsonesuk*/	padding-right: 20px; /*padding-right: 10px; amended by dsonesuk*/	padding-top: 0;	width: 100%; /*added by dsonesuk*/} #mainNav ul ul {	display: none;	width: 300px; /*added by dsonesuk*/position:absolute;  /*added by dsonesuk*/} #mainNav ul ul li {	padding-left: 0 !important;	width: 100%; /*added by dsonesuk*/	z-index: 999 !important;}

    Wow, seriously? Either answer OPs question properly, or don't answer it at all. Providing a long sample of code with a lot of irrelevant chunks will not help the OP, it will only confuse him or her.
×
×
  • Create New...