The security of reading files?

[davej]

Does the presence of a Php file like this pose a security risk?

<?php   header("Content-Type: application/octet-stream");   header("Content-Disposition: attachment; filename=".$_GET['path']);    readfile($_GET['path']);?>

[Ingolme]

If you have your database login information in a file anywhere then this is a security threat.

 

To be safe, remove any / or from the path and restrict the files to one directory that you know doesn't have sensitive information.

 

Using file_exists() first to show an error if the file isn't found would also be a good idea.

[davej]

Removal of slashes is a good idea, and I could also remove any character encoding symbols. Thanks.