Login System Problem

[ATM]

Hello,I have created this login system, but for some wierd reason it started allowing users login using any password. Thankfully Its not protecting anything important at the moment.Anyway I was wondering whether someone could help me find the reason the script allows access to the admin page using any password.Normally I wouldn't ask such a big task but I have been stuck on this for quite a while and I'm really frustrated by it.

<?php/*User Submitted Information*/$username=$_POST["username"];$password=$_POST["password"];/*Users IP Address*/$ip_address=$_SERVER["REMOTE_ADDR"]; /*HTTP REFERER*/$http_referer=parse_url($_SERVER['HTTP_REFERER']);/*Mysql Information*/$mysql_username="******";$mysql_password="******";$mysql_servername="******";$mysql_database="******";/*General Table*/$mysql_fieldname_user_id="user_id";$mysql_fieldname_reference="reference";/*Login Table*/$mysql_tablename_login="login_information";$mysql_fieldname_username="username";$mysql_fieldname_password="password";/*Personal Information Table*/$mysql_tablename_personal_information="personal_information";$mysql_fieldname_title="title";$mysql_fieldname_first_name="first_name";$mysql_fieldname_surname="surname";$mysql_fieldname_company="company";$mysql_fieldname_street_address="street_address";$mysql_fieldname_town="town";$mysql_fieldname_county="county";$mysql_fieldname_country="country";$mysql_fieldname_postcode="postcode";$mysql_fieldname_email_address="email_address";$mysql_fieldname_telephone_number="telephone_number";$mysql_fieldname_website="website";/*Account Information Table*/$mysql_tablename_account_information="account_information";$mysql_fieldname_account_type="account_type";$mysql_fieldname_date_created="date_created";$mysql_fieldname_last_login="last_login";$mysql_fieldname_xml_reference="xml_reference";$mysql_fieldname_xml_version="xml_version";/*Title Reference Table*/$mysql_tablename_title_reference="title_reference";$mysql_fieldname_title="title";/*County Reference Table*/$mysql_tablename_county_reference="county_reference";$mysql_fieldname_county="county";/*Country Reference Table*/$mysql_tablename_country_reference="country_reference";$mysql_fieldname_country="country";/*Login Record Table*/$mysql_tablename_login_record="login_record";/*IP Address Record*/$mysql_tablename_ip_address_record="ip_address_record";$mysql_fieldname_ip_address="ip_address";$mysql_fieldname_failed_attempts="failed_attempts";$mysql_fieldname_status="status";/*Current Timestamp*/$current_timestamp=date("Y-m-d H:i:s");/*Fail Function*/function Fail(){header('Location: ******');@mysql_close($connect);exit();}/*Process HTTP REFERER*/if($http_referer['host']=="******"){unset($http_referer['host']);$http_referer['host']="******";}/*Verify HTTP REFERER*/if($http_referer['host']!="******"){Fail();}/*Process Username*/$username=@stripslashes($username);$username=@strip_tags($username);/*Process Password*/$password=@stripslashes($password);$password=@strip_tags($password);/*Mysql Connect*/$connect=@mysql_connect($mysql_servername,$mysql_username,$mysql_password);if(!$connect){Fail();}/*Mysql Select Database*/$database_select=@mysql_select_db($mysql_database,$connect);if (!$database_select){Fail();}  /*Mysql Login Information Query*/$mysql_username_query=@mysql_query("SELECT * FROM " . $mysql_tablename_login . " WHERE " . $mysql_fieldname_username . "='" . $username . "' LIMIT 1",$connect);$fetch_array_login=@mysql_fetch_array($mysql_username_query);if(!$fetch_array_login){Fail();}/*Insert IP Address*/@mysql_query("INSERT INTO " . $mysql_tablename_ip_address_record . " VALUES ('" . $ip_address . "', '0', '1')");/*Select IP Address*/$mysql_ip_address_record_query=@mysql_query("SELECT * FROM " . $mysql_tablename_ip_address_record . " WHERE " . $mysql_fieldname_ip_address . "='" . $ip_address . "'");if(!$mysql_ip_address_record_query){Fail();}/*Mysql IP Address Query*/$fetch_array_ip_address_record=@mysql_fetch_array($mysql_ip_address_record_query);$failed_attempt=$fetch_array_ip_address_record[$mysql_fieldname_failed_attempts];$ip_address_status=$fetch_array_ip_address_record[$mysql_fieldname_status];/*Verify IP Address*/if($ip_address_status==0){Fail();}/*Process IP Address*/$failed_attempts=$failed_attempt+1;/*Retrieve Password*/$verify=$fetch_array_login[$mysql_fieldname_password];/*Verify Password*/if(!$verify==$password){$verify_password="false";}elseif($verify==$password){$verify_password="true";}/*Process IP Address*/if($failed_attempts%5==0){$block_ip_address="true";}elseif($failed_attempts%5!=0){$block_ip_address="false";}/*Block IP Address*/if($verify_password="true" && $block_ip_address="false"){$login="true";}elseif ($verify_password="false" && $block_ip_address="true"){@mysql_query("UPDATE " . $mysql_tablename_ip_address_record . " SET " . $mysql_fieldname_status . " ='0' WHERE " . $mysql_fieldname_ip_address . " ='" . $ip_address . "'");Fail();}elseif($verify_password="false" && $block_ip_address="false"){@mysql_query("UPDATE " . $mysql_tablename_ip_address_record . " SET " . $mysql_fieldname_failed_attempts . " ='" . $failed_attempts . "' WHERE " . $mysql_fieldname_ip_address . " ='" . $ip_address . "'");Fail();}else{Fail();}/*Get User ID*/$user_id=$fetch_array_login[$mysql_fieldname_user_id];/*Mysql Personal Information Query*/$mysql_personal_information_query=@mysql_query("SELECT * FROM " . $mysql_tablename_personal_information . " WHERE " . $mysql_fieldname_user_id . "='" . $user_id . "' LIMIT 1",$connect);$fetch_array_personal_information=@mysql_fetch_array($mysql_personal_information_query);if(!$fetch_array_personal_information){Fail();}/*Mysql Account Information Query*/$mysql_account_information_query=@mysql_query("SELECT * FROM " . $mysql_tablename_account_information . " WHERE " . $mysql_fieldname_user_id . "='" . $user_id . "' LIMIT 1",$connect);$fetch_array_account_information=@mysql_fetch_array($mysql_account_information_query);if(!$fetch_array_account_information){Fail();}/*Get Personal Information*/$title=$fetch_array_personal_information[$mysql_fieldname_title];$first_name=$fetch_array_personal_information[$mysql_fieldname_first_name];$surname=$fetch_array_personal_information[$mysql_fieldname_surname];$company=$fetch_array_personal_information[$mysql_fieldname_company];$street_address=$fetch_array_personal_information[$mysql_fieldname_street_address];$town=$fetch_array_personal_information[$mysql_fieldname_town];$county=$fetch_array_personal_information[$mysql_fieldname_county];$country=$fetch_array_personal_information[$mysql_fieldname_country];$postcode=$fetch_array_personal_information[$mysql_fieldname_postcode];$email_address=$fetch_array_personal_information[$mysql_fieldname_email_address];$telephone_number=$fetch_array_personal_information[$mysql_fieldname_telephone_number];$website=$fetch_array_personal_information[$mysql_fieldname_website];/*Get Account information*/$account_type=$fetch_array_account_information[$mysql_fieldname_account_type];$date_created=$fetch_array_account_information[$mysql_fieldname_date_created];$last_login=$fetch_array_account_information[$mysql_fieldname_last_login];$xml_reference=$fetch_array_account_information[$mysql_fieldname_xml_reference];$xml_version=$fetch_array_account_information[$mysql_fieldname_xml_version];/*Mysql Title Reference Query*/$mysql_title_reference_query=@mysql_query("SELECT * FROM " . $mysql_tablename_title_reference . " WHERE " . $mysql_fieldname_reference . "='" . $title . "'",$connect);$fetch_array_title_reference=@mysql_fetch_array($mysql_title_reference_query);if(!$fetch_array_title_reference){unset($title);$title=$first_name;}else{unset($title);$title=$fetch_array_title_reference[$mysql_fieldname_title];}/*Mysql County Reference Query*/$mysql_county_reference_query=@mysql_query("SELECT * FROM " . $mysql_tablename_county_reference . " WHERE " . $mysql_fieldname_reference . "='" . $county . "'",$connect);$fetch_array_county_reference=@mysql_fetch_array($mysql_county_reference_query);if(!$fetch_array_county_reference){unset($county);$county="";}else{unset($county);$county=$fetch_array_county_reference[$mysql_fieldname_county];}/*Mysql Country Reference Query*/$mysql_country_reference_query=@mysql_query("SELECT * FROM " . $mysql_tablename_country_reference . " WHERE " . $mysql_fieldname_reference . "='" . $country . "'",$connect);$fetch_array_country_reference=@mysql_fetch_array($mysql_country_reference_query);if(!$fetch_array_country_reference){unset($country);$country="United Kingdom";}else{unset($country);$country=$fetch_array_country_reference[$mysql_fieldname_country];}/*Update Last Login*/@mysql_query("UPDATE account_information SET " . $mysql_fieldname_last_login . " ='" . $current_timestamp . "' WHERE " . $mysql_fieldname_user_id . " ='" . $user_id . "'",$connect);/*Record Successful Login*/@mysql_query("INSERT INTO " . $mysql_tablename_login_record . " VALUES ('" . $user_id . "', '" . $current_timestamp . "', '" . $ip_address . "') LIMIT 1",$connect);/*Mysql Close Connection*/@mysql_close($connect);/*Start Session*/session_start();/*Write Session Variables*/$_SESSION['login']="true";$_SESSION['user_id']=$user_id;$_SESSION['username']=$username;$_SESSION['password']=$password;$_SESSION['title']=$title;$_SESSION['first_name']=$first_name;$_SESSION['surname']=$surname;$_SESSION['company']=$company;$_SESSION['street_address']=$street_address;$_SESSION['town']=$town;$_SESSION['county']=$county;$_SESSION['country']=$country;$_SESSION['postcode']=$postcode;$_SESSION['email_address']=$email_address;$_SESSION['telephone_number']=$telephone_number;$_SESSION['website']=$website;$_SESSION['account_type']=$account_type;$_SESSION['date_created']=$date_created;$_SESSION['last_login']=$last_login;$_SESSION['xml_reference']=$xml_reference;$_SESSION['xml_version']=$xml_version;/*Account Type Redirect*/if($account_type=="1"){header('Location: ******');exit();}elseif($account_type=="0"){header('Location: ******');exit();}else{header('Location: ******');exit();}?>

Thank You.

[justsomeguy]

A few things. You can shorten this:

/*Verify Password*/if(!$verify==$password){$verify_password="false";}elseif($verify==$password){$verify_password="true";}

To this:

/*Verify Password*/if($verify != $password){  $verify_password="false";}else{  $verify_password="true";}

But this is the main problem:

/*Block IP Address*/if($verify_password="true" && $block_ip_address="false"){$login="true";}elseif ($verify_password="false" && $block_ip_address="true"){@mysql_query("UPDATE " . $mysql_tablename_ip_address_record . " SET " . $mysql_fieldname_status . " ='0' WHERE " . $mysql_fieldname_ip_address . " ='" . $ip_address . "'");Fail();}elseif($verify_password="false" && $block_ip_address="false"){@mysql_query("UPDATE " . $mysql_tablename_ip_address_record . " SET " . $mysql_fieldname_failed_attempts . " ='" . $failed_attempts . "' WHERE " . $mysql_fieldname_ip_address . " ='" . $ip_address . "'");Fail();}else{Fail();}

Specifically, lines like this:if($verify_password="true" && $block_ip_address="false")You have 1 equal sign there, which is the assignment operator. So that statement sets $verify_password = "true" and sets $block_ip_address = "false" and then checks the values. The result of that statement will always be false, because it is basically checking if (true && false), but it has the side effect of setting the two variables. There are several if statements in the code I pasted that use = instead of ==. = is assignment and == is comparison.

[ATM]

Thank you.