function within a function not working

[jimfog]

here is a function which contains an inner function that does not work(the inner one) and i cannot figure out why:

function output_week() {	 global  $monthNames1, $newdate,$begweek,$endweek,$startday,$previousmonth,$nextmonth;			 $previousmonday=strtotime('previous monday' , strtotime($newdate));			 $nextsunday=strtotime('next sunday' , strtotime($newdate));			 $thismonday=strtotime('thismonday' , strtotime($newdate));			 $today=getdate();			 echo $previousmonth;		  	 echo '<ul id="days">';	 echo	   '<li><a href=" ' . $_SERVER["PHP_SELF"] ."?newdate=". $begweek . '">Previous week</a><li>';	  	 function test ()	 {		 global  $monthNames1, $newdate,$begweek,$endweek,$startday,$previousmonth,$nextmonth;			 $previousmonday=strtotime('previous monday' , strtotime($newdate));			 $nextsunday=strtotime('next sunday' , strtotime($newdate));			 $thismonday=strtotime('thismonday' , strtotime($newdate));			 $today=getdate();		if(((date("n",$nextsunday ))==($nextmonth))||(($nextmonth==3)&&(date("n",$previousmonday)==1))&&($today[wday]!==1))					{			echo '<li>'. date("d",$previousmonday).$monthNames1[date("n",strtotime($newdate))-1] .		'----'.date("d",$nextsunday ).' '.$monthNames1[date("n",strtotime($newdate))] .		'  ' . date("Y", strtotime($newdate)).'</li>';		  		} 	   elseif(((date("n",$nextsunday ))==($nextmonth))||(($nextmonth==3)&&(date("n",$previousmonday)==1))&&($today[wday]==1)) 	   {echo '<li>'. date("d",$thismonday).$monthNames1[date("n",strtotime($newdate))-1] .			   '--'.date("d",$nextsunday ).''. $monthNames1[date("n",strtotime($newdate))] .			   '  ' . date("Y", strtotime($newdate)).'</li>';}	   	   else	  	  	   {echo '<li>'. date("d",$previousmonday).	   '----'.date("d",$nextsunday ).''. $monthNames1[date("n",strtotime($newdate))-1] .			   '  ' . date("Y", strtotime($newdate)).'</li>';}	 }	   echo   '<li><a href=" ' . $_SERVER["PHP_SELF"] ."?newdate=".$endweek. '">Next week</a><li>';	   echo  '</ul>';	  }

Above, function test is not executed-any ideas why?

[boen_robot]

Why should it? I don't see you calling it anywhere... you're just defining it within the function. If after its declaration you have something like

           test();           echo   '<li><a href=" ' . $_SERVER["PHP_SELF"] ."?newdate=".$endweek. '">Next week</a><li>';           echo  '</ul>';

it should work.

[jimfog]

oh...how did i miss that little detail. Thanks.

[justsomeguy]

It's not a very good idea to define a function inside another function. If you execute output_week more than once you'll get a fatal error because you're trying to declare a function that already exists.

[jimfog]

So, in other words, i should define the inner function outside if output_week.

[boen_robot]

Yes, or if they're too closely coupled and the inner function doesn't make sense, make a class that holds the two functions, and make the inner function a private method.

[jimfog]

...make a class that holds the two functions, and make the inner function a private method.

I do not know a lot from classes yet(i still develop functionally) but it seems this a good point to begin experimenting with them.