PDO prepare with two separated variables

[ckrudelux]

<?php $pdo = new PDO(...);$insert = $pdo->prepare(...);$update = $pdo->prepare(...); $items = array(...); foreach($items as $item)  if($item->id)   $update->execute(...);  else   $insert->execute(...);

The value of $insert becomes TRUE while $update becomes a PDOStatement object.Why doesn't both of them become a PDOStatement?

[birbal]

both of them should return pdostatement object on success. how did you test it? can you post the exact code?

[ckrudelux]

both of them should return pdostatement object on success. how did you test it? can you post the exact code?

This is the exact code but it should be the same as the example.

private function updateChildren(Menu $menu){   if(count($menu->getItems())){	if($insert = DB::PDO()->prepare("INSERT INTO `menu` (`label`,`path`,`parent`) VALUES (:label, :path, '". intval($menu->getID()) ."')") && $update = DB::PDO()->prepare("UPDATE `menu` SET `label`=:label, `path`=:path WHERE id=:id")){	 foreach($menu->getItems() as $item){	  if($item->getID()){	   if($update->execute(array("label"=>$item->getLabel(),"path"=>$item->getPath(),"id"=>$item->getID()))){		$this->updateChildren($item);	   }	  }else{	   if($insert->execute(array("label"=>$item->getLabel(),"path"=>$item->getPath()))){		$item->__construct(intval(DB::PDO()->lastInsertID()));		$this->updateChildren($item);	   }	  }	 }	}   }   if(count($menu->getRemoved())){	foreach($menu->getRemoved() as $remove)	 $this->removeMenu($remove);   }  }

I tested it by var_dump() the insert and update variables

Edited September 4, 2012 by ckrudelux

[justsomeguy]

This line: if($insert = DB::PDO()->prepare("INSERT INTO `menu` (`label`,`path`,`parent`) VALUES (:label, :path, '". intval($menu->getID()) ."')") && $update = DB::PDO()->prepare("UPDATE `menu` SET `label`=:label, `path`=:path WHERE id=:id")){ Is going to set $insert to be the result of the logical && operator. It parses that line like this: if($insert = (DB::PDO()->prepare("INSERT INTO `menu` (`label`,`path`,`parent`) VALUES (:label, :path, '". intval($menu->getID()) ."')") && $update = DB::PDO()->prepare("UPDATE `menu` SET `label`=:label, `path`=:path WHERE id=:id"))){ you want it like this: if(($insert = DB::PDO()->prepare("INSERT INTO `menu` (`label`,`path`,`parent`) VALUES (:label, :path, '". intval($menu->getID()) ."')")) && ($update = DB::PDO()->prepare("UPDATE `menu` SET `label`=:label, `path`=:path WHERE id=:id"))){

[ckrudelux]

This line: if($insert = DB::PDO()->prepare("INSERT INTO `menu` (`label`,`path`,`parent`) VALUES (:label, :path, '". intval($menu->getID()) ."')") && $update = DB::PDO()->prepare("UPDATE `menu` SET `label`=:label, `path`=:path WHERE id=:id")){ Is going to set $insert to be the result of the logical && operator. It parses that line like this: if($insert = (DB::PDO()->prepare("INSERT INTO `menu` (`label`,`path`,`parent`) VALUES (:label, :path, '". intval($menu->getID()) ."')") && $update = DB::PDO()->prepare("UPDATE `menu` SET `label`=:label, `path`=:path WHERE id=:id"))){ you want it like this: if(($insert = DB::PDO()->prepare("INSERT INTO `menu` (`label`,`path`,`parent`) VALUES (:label, :path, '". intval($menu->getID()) ."')")) && ($update = DB::PDO()->prepare("UPDATE `menu` SET `label`=:label, `path`=:path WHERE id=:id"))){

Oh.. should have thought about that.. thank you very much